Re: [systemd-devel] [PATCH 2/2] localectl: print warning when there are options given on kernel cmdline

2014-10-03 Thread Michal Sekletar
On Thu, Oct 02, 2014 at 02:39:10PM +0200, Lennart Poettering wrote: On Wed, 24.09.14 17:18, Michal Sekletar (msekl...@redhat.com) wrote: Heya, +for (j = VARIABLE_LANG; j _VARIABLE_LC_MAX; j++) I think it is much nicer to count from an explicit 0 on here, instead of

Re: [systemd-devel] [PATCH 2/2] localectl: print warning when there are options given on kernel cmdline

2014-10-02 Thread Lennart Poettering
On Wed, 24.09.14 17:18, Michal Sekletar (msekl...@redhat.com) wrote: Heya, +for (j = VARIABLE_LANG; j _VARIABLE_LC_MAX; j++) I think it is much nicer to count from an explicit 0 on here, instead of VARIABLE_LANG, since this makes the loop work correctly even if the order of the enum

Re: [systemd-devel] [PATCH 2/2] localectl: print warning when there are options given on kernel cmdline

2014-09-25 Thread Michal Sekletar
On Thu, Sep 25, 2014 at 04:47:58AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Sep 24, 2014 at 05:18:47PM +0200, Michal Sekletar wrote: --- src/core/locale-setup.c | 47 + src/locale/localectl.c | 50

Re: [systemd-devel] [PATCH 2/2] localectl: print warning when there are options given on kernel cmdline

2014-09-24 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Sep 24, 2014 at 05:18:47PM +0200, Michal Sekletar wrote: --- src/core/locale-setup.c | 47 + src/locale/localectl.c | 50 src/shared/locale-util.c | 20 +++