Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-29 Thread Tom Gundersen
On Fri, Jun 27, 2014 at 7:58 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 26.06.14 12:49, Eugene Yakubovich (eyakubov...@gmail.com) wrote: On Thu, Jun 26, 2014 at 11:17 AM, Lennart Poettering lenn...@poettering.net wrote: I am tempted to say that we should try to apply as

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-29 Thread Tom Gundersen
On Fri, Jun 27, 2014 at 8:09 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Lennart, I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Marcel Holtmann
Hi Lennart, I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that manual routes always win, or routes to other interfaces. I think using

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Lennart Poettering
On Thu, 26.06.14 12:49, Eugene Yakubovich (eyakubov...@gmail.com) wrote: On Thu, Jun 26, 2014 at 11:17 AM, Lennart Poettering lenn...@poettering.net wrote: I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Eugene Yakubovich
On Fri, Jun 27, 2014 at 11:09 AM, Marcel Holtmann mar...@holtmann.org wrote: Hmm, something in the middle of the range, I figure, that is still nice to type and look at for whatever that is. pick something... Also I figure the default route added due to dhcp config should also use this same

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-26 Thread Lennart Poettering
On Wed, 25.06.14 18:03, Eugene Yakubovich (eyakubov...@gmail.com) wrote: This adds support for DHCP options 33 and 121: Static Route and Classless Static Route. To enable this feature, set UseRoutes=true in .network file. Returned routes are added to the routing table. The patch is

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-26 Thread Eugene Yakubovich
On Wed, 25.06.14 18:03, Eugene Yakubovich (eyakubov...@gmail.com) wrote: The patch is line-broken I resent it last night with [PATCH resent] in the subject. Is that one also line broken? It was resent with git send-email so should be ok. Just one quick question without looking into much

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-26 Thread Lennart Poettering
On Thu, 26.06.14 10:37, Eugene Yakubovich (eyakubov...@gmail.com) wrote: On Wed, 25.06.14 18:03, Eugene Yakubovich (eyakubov...@gmail.com) wrote: The patch is line-broken I resent it last night with [PATCH resent] in the subject. Is that one also line broken? It was resent with git

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-26 Thread Eugene Yakubovich
On Thu, Jun 26, 2014 at 11:17 AM, Lennart Poettering lenn...@poettering.net wrote: I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that manual

[systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-25 Thread Eugene Yakubovich
This adds support for DHCP options 33 and 121: Static Route and Classless Static Route. To enable this feature, set UseRoutes=true in .network file. Returned routes are added to the routing table. --- man/systemd.network.xml | 7 ++