Re: [systemd-devel] [PATCH] Fix off-by-one error in "Missed X kernel messages" warning

2014-08-13 Thread Lennart Poettering
On Wed, 06.08.14 13:14, Eelco Dolstra (eelco.dols...@logicblox.com) wrote:

> On receiving a message, "kernel_seqnum" is set to "serial + 1". So
> subtracting 1 will cause messages like "Missed 0 kernel messages",
> which should be "Missed 1 kernel messages".

Ah! Thanks! Applied!

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH] Fix off-by-one error in "Missed X kernel messages" warning

2014-08-06 Thread Eelco Dolstra
On receiving a message, "kernel_seqnum" is set to "serial + 1". So
subtracting 1 will cause messages like "Missed 0 kernel messages",
which should be "Missed 1 kernel messages".
---
 src/journal/journald-kmsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c
index 9935986..fb8ea08 100644
--- a/src/journal/journald-kmsg.c
+++ b/src/journal/journald-kmsg.c
@@ -152,7 +152,7 @@ static void dev_kmsg_record(Server *s, char *p, size_t l) {
 /* Did we lose any? */
 if (serial > *s->kernel_seqnum)
 server_driver_message(s, SD_MESSAGE_JOURNAL_MISSED, 
"Missed %"PRIu64" kernel messages",
-  serial - *s->kernel_seqnum - 1);
+  serial - *s->kernel_seqnum);
 
 /* Make sure we never read this one again. Note that
  * we always store the next message serial we expect
-- 
1.9.2

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel