Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Mon, 08.06.15 12:29, Lennart Poettering (lenn...@poettering.net) wrote: > On Wed, 03.06.15 11:23, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: > > > On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > >

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Mon, Jun 08, 2015 at 12:29:51PM +0200, Lennart Poettering wrote: > On Thu, 04.06.15 13:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Wed, Jun 03, 2015 at 11:23:51AM -0400, Mimi Zohar wrote: > > > On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: > > > > On Tue,

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Thu, 04.06.15 13:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Wed, Jun 03, 2015 at 11:23:51AM -0400, Mimi Zohar wrote: > > On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: > > > On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > > > > > >

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Wed, 03.06.15 11:23, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: > > On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > > > > We could add another parameter to copy_bytes(), but in this case it's > > > > cl

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Wed, Jun 03, 2015 at 11:23:51AM -0400, Mimi Zohar wrote: > On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: > > On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > > > > We could add another parameter to copy_bytes(), but in this case it's > > > > cleaner to c

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Wed, 2015-06-03 at 06:50 +0200, Lennart Poettering wrote: > On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > > We could add another parameter to copy_bytes(), but in this case it's > > > cleaner to call fstat() and loop_write(). > > > > Right. copy_bytes has no conce

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Tue, 02.06.15 11:55, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > We could add another parameter to copy_bytes(), but in this case it's > > cleaner to call fstat() and loop_write(). > > Right. copy_bytes has no concept of rules/records. So either "another > parameter" is added to copy_by

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Tue, 02.06.15 15:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Tue, Jun 02, 2015 at 04:17:04PM +0200, Lennart Poettering wrote: > > On Mon, 01.06.15 12:36, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > > > On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: > > > > On M

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Tue, 2015-06-02 at 15:28 +, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jun 02, 2015 at 04:17:04PM +0200, Lennart Poettering wrote: > > On Mon, 01.06.15 12:36, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > > > On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: > > > > On Mon, 2015-0

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Tue, Jun 02, 2015 at 04:17:04PM +0200, Lennart Poettering wrote: > On Mon, 01.06.15 12:36, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > > > On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: > > > On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: > > > > --- > > > > OK,

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Mon, 01.06.15 12:36, Mimi Zohar (zo...@linux.vnet.ibm.com) wrote: > On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: > > On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: > > > --- > > > OK, that's strange. Because the error message comes from copy_bytes() > > > failing

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Mon, Jun 01, 2015 at 12:36:25PM -0400, Mimi Zohar wrote: > On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: > > On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: > > > --- > > > OK, that's strange. Because the error message comes from copy_bytes() > > > failing, > > > an

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Mon, 2015-06-01 at 11:57 -0400, Mimi Zohar wrote: > On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: > > --- > > OK, that's strange. Because the error message comes from copy_bytes() > > failing, > > and in copy_bytes() EINVAL could only originate in loop_write(), unless >

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

On Mon, 2015-06-01 at 10:36 -0400, Zbigniew Jędrzejewski-Szmek wrote: > --- > OK, that's strange. Because the error message comes from copy_bytes() failing, > and in copy_bytes() EINVAL could only originate in loop_write(), unless > I'm missing something. Can you check the following patch, which es

Re: [systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH] Partially revert "ma-setup: simplify"

--- OK, that's strange. Because the error message comes from copy_bytes() failing, and in copy_bytes() EINVAL could only originate in loop_write(), unless I'm missing something. Can you check the following patch, which essentially reverts to the old copy method? Zbyszek src/core/ima-setup.c | 17