Re: [systemd-devel] [PATCH] bash-completion: fix systemctl isolate
Jan Synacek jsyna...@redhat.com writes: Jan Synacek (1): bash-completion: fix systemctl isolate I've just tested the latest systemd (commit 81333ec) and after the bash-completion patches, this patch seems obsolete and not needed anymore. -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] bash-completion: fix systemctl isolate
On Thu, 09.10.14 12:03, Jan Synacek (jsyna...@redhat.com) wrote:
Patch looks good, but I'll leave this for Zbigniew to merge, as my own
expertise is bash completion stuff is pretty limited.
---
shell-completion/bash/systemctl.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/shell-completion/bash/systemctl.in
b/shell-completion/bash/systemctl.in
index 0150018..e47c028 100644
--- a/shell-completion/bash/systemctl.in
+++ b/shell-completion/bash/systemctl.in
@@ -67,6 +67,8 @@ __get_disabled_units () { __systemctl $1 list-unit-files \
| { while read -r a b c ; do [[ $b == disabled ]] echo $a;
done; }; }
__get_masked_units () { __systemctl $1 list-unit-files \
| { while read -r a b c ; do [[ $b == masked ]] echo $a;
done; }; }
+__get_all_targets() { { __systemctl $1 list-units -t target --all; } \
+| { while read -r a b; do echo $a; done; }; }
_systemctl () {
local cur=${COMP_WORDS[COMP_CWORD]} prev=${COMP_WORDS[COMP_CWORD-1]}
@@ -198,7 +200,7 @@ _systemctl () {
elif __contains_word $verb ${VERBS[ISOLATABLE_UNITS]}; then
comps=$( __filter_units_by_property $mode AllowIsolate yes \
- $( __get_all_units $mode ) )
+ $( __get_all_targets $mode ) )
compopt -o filenames
elif __contains_word $verb ${VERBS[FAILED_UNITS]}; then
--
1.9.3
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Lennart
--
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH] bash-completion: fix systemctl isolate
I didn't dare fix this in zsh completion (not sure if it's required, though, so I didn't even remove the TODO entry that mentions this fix is required). Jan Synacek (1): bash-completion: fix systemctl isolate shell-completion/bash/systemctl.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.9.3 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] bash-completion: fix systemctl isolate
On Thu, 09.10.14 12:03, Jan Synacek (jsyna...@redhat.com) wrote: I didn't dare fix this in zsh completion (not sure if it's required, though, so I didn't even remove the TODO entry that mentions this fix is required). Jan Synacek (1): bash-completion: fix systemctl isolate shell-completion/bash/systemctl.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Hmm, the actual patch is missing? Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] bash-completion: fix systemctl isolate
Lennart Poettering lenn...@poettering.net writes: On Thu, 09.10.14 12:03, Jan Synacek (jsyna...@redhat.com) wrote: I didn't dare fix this in zsh completion (not sure if it's required, though, so I didn't even remove the TODO entry that mentions this fix is required). Jan Synacek (1): bash-completion: fix systemctl isolate shell-completion/bash/systemctl.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Hmm, the actual patch is missing? Nope, I can see it in my mail and it the systemd-devel archives as well. This is just a cover letter I used to explain additional stuff. -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] bash-completion: fix systemctl isolate
On Thu, 09.10.14 12:55, Jan Synacek (jsyna...@redhat.com) wrote: Lennart Poettering lenn...@poettering.net writes: On Thu, 09.10.14 12:03, Jan Synacek (jsyna...@redhat.com) wrote: I didn't dare fix this in zsh completion (not sure if it's required, though, so I didn't even remove the TODO entry that mentions this fix is required). Jan Synacek (1): bash-completion: fix systemctl isolate shell-completion/bash/systemctl.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Hmm, the actual patch is missing? Nope, I can see it in my mail and it the systemd-devel archives as well. This is just a cover letter I used to explain additional stuff. Hmm, there's something wrong with mail delivery on fdo as it seems. Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
