Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-12-02 Thread Peter Wu
On Monday 01 December 2014 01:06:12 Lennart Poettering wrote: On Mon, 24.11.14 20:00, Peter Wu (pe...@lekensteyn.nl) wrote: The --gc-sections linker option triggers a bug in the gold linker[1] which results in a bogus .eh_frame section making debugging harder: gdb backtraces stop at a

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-30 Thread Lennart Poettering
On Mon, 24.11.14 20:00, Peter Wu (pe...@lekensteyn.nl) wrote: The --gc-sections linker option triggers a bug in the gold linker[1] which results in a bogus .eh_frame section making debugging harder: gdb backtraces stop at a library built by systemd and libunwind simply segfaults. To my

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread David Herrmann
Hi On Wed, Nov 26, 2014 at 6:40 PM, Gustavo Sverzut Barbieri gustavo.barbi...@intel.com wrote: On Wed, Nov 26, 2014 at 06:33:31PM +0100, Lennart Poettering wrote: On Wed, 26.11.14 15:16, Gustavo Sverzut Barbieri (gustavo.barbi...@intel.com) wrote: I'm okay with the change to remove

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread Peter Wu
On Thursday 27 November 2014 15:42:37 David Herrmann wrote: We _really_ depend on --gc-sections. We link a lot of stuff from src/shared/ statically into all binaries and expect the linker to drop any unused symbols. Note that none of the symbols from src/shared/ are exported, so the linker can

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread Gustavo Sverzut Barbieri
On Thu, Nov 27, 2014 at 03:42:37PM +0100, David Herrmann wrote: Hi On Wed, Nov 26, 2014 at 6:40 PM, Gustavo Sverzut Barbieri gustavo.barbi...@intel.com wrote: On Wed, Nov 26, 2014 at 06:33:31PM +0100, Lennart Poettering wrote: On Wed, 26.11.14 15:16, Gustavo Sverzut Barbieri

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread David Herrmann
Hi On Thu, Nov 27, 2014 at 4:42 PM, Gustavo Sverzut Barbieri gustavo.barbi...@intel.com wrote: On Thu, Nov 27, 2014 at 03:42:37PM +0100, David Herrmann wrote: Hi On Wed, Nov 26, 2014 at 6:40 PM, Gustavo Sverzut Barbieri gustavo.barbi...@intel.com wrote: On Wed, Nov 26, 2014 at 06:33:31PM

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread Peter Wu
On Thursday 27 November 2014 13:42:27 Gustavo Sverzut Barbieri wrote: I'm asking because from Peter Wu's email we're 26384 - 26380 = 4Kb heavier in the whole installed set of binaries. If this is correct I doubt the gc-sections is making any difference in the linkage of static libraries

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread David Herrmann
Hi On Thu, Nov 27, 2014 at 6:35 PM, Peter Wu pe...@lekensteyn.nl wrote: On Thursday 27 November 2014 13:42:27 Gustavo Sverzut Barbieri wrote: I'm asking because from Peter Wu's email we're 26384 - 26380 = 4Kb heavier in the whole installed set of binaries. If this is correct I doubt the

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread Gustavo Sverzut Barbieri
On Thu, Nov 27, 2014 at 06:50:19PM +0100, David Herrmann wrote: Hi On Thu, Nov 27, 2014 at 6:35 PM, Peter Wu pe...@lekensteyn.nl wrote: On Thursday 27 November 2014 13:42:27 Gustavo Sverzut Barbieri wrote: I'm asking because from Peter Wu's email we're 26384 - 26380 = 4Kb heavier in the

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread David Herrmann
Hi On Thu, Nov 27, 2014 at 7:31 PM, Gustavo Sverzut Barbieri gustavo.barbi...@intel.com wrote: Currently configure.ac has the LTO logic inside an: AS_CASE([$CFLAGS], [*-O[[12345\ ]]*], We can make the else block check/enable for gc-sections alongside printing the result. See

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-27 Thread Gustavo Sverzut Barbieri
On Thu, Nov 27, 2014 at 07:36:12PM +0100, David Herrmann wrote: Hi On Thu, Nov 27, 2014 at 7:31 PM, Gustavo Sverzut Barbieri gustavo.barbi...@intel.com wrote: Currently configure.ac has the LTO logic inside an: AS_CASE([$CFLAGS], [*-O[[12345\ ]]*], We can make the else

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Peter Wu
(cc'ing Zbigniew because he introduced gold, cc'ing Gustavo because he added --gc-sections) On Monday 24 November 2014 20:00:58 Peter Wu wrote: The --gc-sections linker option triggers a bug in the gold linker[1] which results in a bogus .eh_frame section making debugging harder: gdb backtraces

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Gustavo Sverzut Barbieri
On Wed, Nov 26, 2014 at 03:28:15PM +0100, Peter Wu wrote: (cc'ing Zbigniew because he introduced gold, cc'ing Gustavo because he added --gc-sections) On Monday 24 November 2014 20:00:58 Peter Wu wrote: The --gc-sections linker option triggers a bug in the gold linker[1] which results in a

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Michael Biebl
2014-11-26 18:16 GMT+01:00 Gustavo Sverzut Barbieri gustavo.barbi...@intel.com: My only comment is that we should also remove: -ffunction-sections -fdata-sections those are only useful to enable gc-sections. From time to time someone should run a build with

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Lennart Poettering
On Wed, 26.11.14 15:16, Gustavo Sverzut Barbieri (gustavo.barbi...@intel.com) wrote: I'm okay with the change to remove gc-sections. systemd is pretty good at not leaving crap in its code, then results are pretty small as we saw. My only comment is that we should also remove:

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Gustavo Sverzut Barbieri
On Wed, Nov 26, 2014 at 06:27:45PM +0100, Michael Biebl wrote: 2014-11-26 18:16 GMT+01:00 Gustavo Sverzut Barbieri gustavo.barbi...@intel.com: My only comment is that we should also remove: -ffunction-sections -fdata-sections those are only useful to enable gc-sections.

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Gustavo Sverzut Barbieri
On Wed, Nov 26, 2014 at 06:33:31PM +0100, Lennart Poettering wrote: On Wed, 26.11.14 15:16, Gustavo Sverzut Barbieri (gustavo.barbi...@intel.com) wrote: I'm okay with the change to remove gc-sections. systemd is pretty good at not leaving crap in its code, then results are pretty small

[systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-24 Thread Peter Wu
The --gc-sections linker option triggers a bug in the gold linker[1] which results in a bogus .eh_frame section making debugging harder: gdb backtraces stop at a library built by systemd and libunwind simply segfaults. Workaround by that bug by removing the option. The additional disk space saved