[systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units) [r2]

2015-05-27 Thread Charles Duffy
From: Charles Duffy chadu...@cisco.com Replace the single -r (raw) option with separate flags for memory and IO, patterned off of --cpu[=TYPE], per feedback from Umut. Fold repeated conditional logic around formatting into a static function, per feedback from Zbyszek. Charles Duffy (1):

Re: [systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units)

2015-05-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, May 22, 2015 at 04:56:15PM -0500, Charles Duffy wrote: From: Charles Duffy chadu...@cisco.com --- src/cgtop/cgtop.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index a390cf3..0dbac7f

[systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units)

2015-05-27 Thread Charles Duffy
From: Charles Duffy chadu...@cisco.com --- src/cgtop/cgtop.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index a390cf3..2849a1d 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -62,6 +62,7

[systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units) [r3]

2015-05-27 Thread Charles Duffy
From: Charles Duffy chadu...@cisco.com Another take, incorporating feedback from r2. Charles Duffy (1): cgtop: raw output option (disable conversion to human-readable units) src/cgtop/cgtop.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) --

Re: [systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units)

2015-05-27 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432339750-31673-2-git-send-email-charles%40dyfis.net -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units)

2015-05-27 Thread Umut Tezduyar Lindskog
Hi Charles, We have done something similar to this with the cpu accounting. The option is --cpu=TYPE (There is also hidden key '%' on the tty output which toggles between different display modes). If this patch will be taken I think we should be consistent. Maybe something like --io=TYPE or

Re: [systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units)

2015-05-26 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432331775-28932-2-git-send-email-charles%40dyfis.net -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH] cgtop: raw output option (disable conversion to human-readable units)

2015-05-26 Thread Charles Duffy
From: Charles Duffy chadu...@cisco.com --- src/cgtop/cgtop.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index a390cf3..0dbac7f 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -62,6 +62,7 @@