[systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Michal Sekletar
We should not try to get information about mount unit from fragment if the unit was created because of /proc/self/mountinfo event. --- src/core/mount.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/mount.c b/src/core/mount.c index 419cf27..df9 100644 ---

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Michal Sekletar
Hi everyone, I haven't tested the patch, so suggestions and testing are very appreciated. Regards, Michal ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Umut Tezduyar
Hi, I thought mounts coming from mountinfo are not getting default dependencies anyways. mount_add_one() never sets load_extras to true for new mount units. load_extras is the control to call mount_add_extras which will eventually call mount_add_default_dependencies(). Or I have replied to

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Michal Schmidt
On 03/08/2013 03:13 PM, Michal Sekletar wrote: @@ -447,7 +447,11 @@ static int mount_add_default_dependencies(Mount *m) { if (UNIT(m)-manager-running_as != SYSTEMD_SYSTEM) return 0; -p = get_mount_parameters_fragment(m); +if (m-from_fragment) +

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Michal Schmidt
On 03/08/2013 03:25 PM, Umut Tezduyar wrote: I thought mounts coming from mountinfo are not getting default dependencies anyways. mount_add_one() never sets load_extras to true for new mount units. But it does call unit_add_to_load_queue(u), which should eventually result in mount_load()

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Harald Hoyer
Am 08.03.2013 15:49, schrieb Michal Schmidt: On 03/08/2013 03:25 PM, Umut Tezduyar wrote: I thought mounts coming from mountinfo are not getting default dependencies anyways. mount_add_one() never sets load_extras to true for new mount units. But it does call unit_add_to_load_queue(u),