Re: [systemd-devel] [PATCH] core: map the 'rescue' argument to rescue.target

2014-10-08 Thread Lennart Poettering
On Tue, 07.10.14 14:55, Mantas Mikulėnas (graw...@gmail.com) wrote:

 Even though the 'emergency' and 'single' aliases come from sysvinit, the
 lack of 'rescue' is still quite confusing (caught me by surprise for the
 9th time yet) and inconsistent with `systemctl rescue` as well.

Hmm, so I am normally conservative for adding non-prefixed new command
line arguments. THe ones we support exclusively exist for compat with
sysvinit.

However, you got me with the systemctl comparison, so I did merge
this now. We should be very careful though to add even more.

 ---
  src/core/main.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/src/core/main.c b/src/core/main.c
 index 1a62e04..44373cc 100644
 --- a/src/core/main.c
 +++ b/src/core/main.c
 @@ -272,6 +272,7 @@ static int parse_proc_cmdline_item(const char *key, const 
 char *value) {
  static const char * const rlmap[] = {
  emergency, SPECIAL_EMERGENCY_TARGET,
  -b,SPECIAL_EMERGENCY_TARGET,
 +rescue,SPECIAL_RESCUE_TARGET,
  single,SPECIAL_RESCUE_TARGET,
  -s,SPECIAL_RESCUE_TARGET,
  s, SPECIAL_RESCUE_TARGET,
 -- 
 2.1.2
 
 ___
 systemd-devel mailing list
 systemd-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/systemd-devel
 


Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH] core: map the 'rescue' argument to rescue.target

2014-10-07 Thread Mantas Mikulėnas
Even though the 'emergency' and 'single' aliases come from sysvinit, the
lack of 'rescue' is still quite confusing (caught me by surprise for the
9th time yet) and inconsistent with `systemctl rescue` as well.
---
 src/core/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/core/main.c b/src/core/main.c
index 1a62e04..44373cc 100644
--- a/src/core/main.c
+++ b/src/core/main.c
@@ -272,6 +272,7 @@ static int parse_proc_cmdline_item(const char *key, const 
char *value) {
 static const char * const rlmap[] = {
 emergency, SPECIAL_EMERGENCY_TARGET,
 -b,SPECIAL_EMERGENCY_TARGET,
+rescue,SPECIAL_RESCUE_TARGET,
 single,SPECIAL_RESCUE_TARGET,
 -s,SPECIAL_RESCUE_TARGET,
 s, SPECIAL_RESCUE_TARGET,
-- 
2.1.2

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel