Re: [systemd-devel] [PATCH] login: share VT-signal handler between sessions

2014-08-13 Thread David Herrmann
Hi On Mon, Aug 11, 2014 at 7:57 PM, Olivier Brunel j...@jjacky.com wrote: On 08/11/14 18:21, David Herrmann wrote: sd-event does not allow multiple handlers for a single signal. However, logind sets up signal handlers for each session with VT_PROCESS set (that is, it has an active

[systemd-devel] [PATCH] login: share VT-signal handler between sessions

2014-08-11 Thread David Herrmann
sd-event does not allow multiple handlers for a single signal. However, logind sets up signal handlers for each session with VT_PROCESS set (that is, it has an active controller). Therefore, registering multiple such controllers will fail. Lets make the VT-handler global, as it's mostly trivial,

Re: [systemd-devel] [PATCH] login: share VT-signal handler between sessions

2014-08-11 Thread Lennart Poettering
On Mon, 11.08.14 18:21, David Herrmann (dh.herrm...@gmail.com) wrote: +/* + * SIGRTMIN is used as global VT-release signal, SIGRTMIN + 1 is used + * as VT-acquire signal. We ignore any acquire-events (yes, we still + * have to provide a valid signal-number for

Re: [systemd-devel] [PATCH] login: share VT-signal handler between sessions

2014-08-11 Thread Lennart Poettering
On Mon, 11.08.14 18:46, Lennart Poettering (lenn...@poettering.net) wrote: With this code you block, but do not ignore SGRTMIN+1. Now, rtsigs actually are implemented in a queue, multiple instances of the same signal might be queued up. If you simply block dispatching, then the queue will

Re: [systemd-devel] [PATCH] login: share VT-signal handler between sessions

2014-08-11 Thread David Herrmann
Hi On Mon, Aug 11, 2014 at 6:54 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 11.08.14 18:46, Lennart Poettering (lenn...@poettering.net) wrote: With this code you block, but do not ignore SGRTMIN+1. Now, rtsigs actually are implemented in a queue, multiple instances of the

Re: [systemd-devel] [PATCH] login: share VT-signal handler between sessions

2014-08-11 Thread Olivier Brunel
On 08/11/14 18:21, David Herrmann wrote: sd-event does not allow multiple handlers for a single signal. However, logind sets up signal handlers for each session with VT_PROCESS set (that is, it has an active controller). Therefore, registering multiple such controllers will fail. Lets make