[systemd-devel] [PATCH] networkd: Initialize variable to NULL

2013-11-27 Thread Patrik Flykt 
If any number of arguments are given, _cleanup_manager_free_ is used
with unitialized memory causing a crash.
---
 src/network/networkd.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/network/networkd.c b/src/network/networkd.c
index 1d43361..360afba 100644
--- a/src/network/networkd.c
+++ b/src/network/networkd.c
@@ -25,7 +25,7 @@
 #include networkd.h
 
 int main(int argc, char *argv[]) {
-_cleanup_manager_free_ Manager *m;
+_cleanup_manager_free_ Manager *m = NULL;
 int r;
 
 log_set_target(LOG_TARGET_AUTO);
-- 
1.7.10.4

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] networkd: Initialize variable to NULL

2013-11-27 Thread Tom Gundersen 
On Wed, Nov 27, 2013 at 4:28 PM, Patrik Flykt
patrik.fl...@linux.intel.com wrote:
 If any number of arguments are given, _cleanup_manager_free_ is used
 with unitialized memory causing a crash.
 ---
  src/network/networkd.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/network/networkd.c b/src/network/networkd.c
 index 1d43361..360afba 100644
 --- a/src/network/networkd.c
 +++ b/src/network/networkd.c
 @@ -25,7 +25,7 @@
  #include networkd.h

  int main(int argc, char *argv[]) {
 -_cleanup_manager_free_ Manager *m;
 +_cleanup_manager_free_ Manager *m = NULL;
  int r;

  log_set_target(LOG_TARGET_AUTO);
 --
 1.7.10.4


Thanks! Applied.

-t
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel