Re: [systemd-devel] [PATCH] networkd: use valid bus paths

2015-02-10 Thread Tom Gundersen
On Tue, Feb 10, 2015 at 9:02 PM, Lennart Poettering wrote: > On Fri, 06.02.15 22:35, Mantas Mikulėnas (graw...@gmail.com) wrote: > >> Object path components must start with [A-Za-z_] (AFAIK). >> Also the value of 'p' is undefined if asprintf fails. > > Well, asprintf() the way glibc defines it doe

Re: [systemd-devel] [PATCH] networkd: use valid bus paths

2015-02-10 Thread Matthias Urlichs
Hi, Mantas Mikulėnas: > Object path components must start with [A-Za-z_] (AFAIK). > Also the value of 'p' is undefined if asprintf fails. IMHO you should not put two unrelated issues in one patch. -- -- Matthias Urlichs ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH] networkd: use valid bus paths

2015-02-10 Thread Lennart Poettering
On Fri, 06.02.15 22:35, Mantas Mikulėnas (graw...@gmail.com) wrote: > Object path components must start with [A-Za-z_] (AFAIK). > Also the value of 'p' is undefined if asprintf fails. Well, asprintf() the way glibc defines it does not clobber the passed-in pointer on failure. We rely on that all

Re: [systemd-devel] [PATCH] networkd: use valid bus paths

2015-02-08 Thread Tom Gundersen
Applied. Thanks! On Fri, Feb 6, 2015 at 9:35 PM, Mantas Mikulėnas wrote: > Object path components must start with [A-Za-z_] (AFAIK). > Also the value of 'p' is undefined if asprintf fails. > Compare to user_bus_path() in src/login/logind-user-dbus.c:281. > --- > src/network/networkd-link-bus.c |

[systemd-devel] [PATCH] networkd: use valid bus paths

2015-02-06 Thread Mantas Mikulėnas
Object path components must start with [A-Za-z_] (AFAIK). Also the value of 'p' is undefined if asprintf fails. Compare to user_bus_path() in src/login/logind-user-dbus.c:281. --- src/network/networkd-link-bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/n