Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 7:31 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Mar 11, 2015 at 05:22:18PM -0700, Shawn Landden wrote: >> Still use helper when Xen Dom0, to avoid duplicating some hairy code. >> >> I think the rbtree version was far more understandable as greedy_realloc0() >> is very

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 11, 2015 at 05:22:18PM -0700, Shawn Landden wrote: > Still use helper when Xen Dom0, to avoid duplicating some hairy code. > > I think the rbtree version was far more understandable as greedy_realloc0() > is very messy to do correctly. > > Take fopenat() from lsof. > Add opendirat() >

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Kay Sievers
On Thu, Mar 12, 2015 at 2:36 AM, Shawn Landden wrote: > On Wed, Mar 11, 2015 at 6:24 PM, Kay Sievers wrote: >> >> On Thu, Mar 12, 2015 at 2:07 AM, Shawn Landden >> wrote: >> > On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers wrote: >> >> >> >> On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden >> >> w

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
On Wed, Mar 11, 2015 at 6:24 PM, Kay Sievers wrote: > On Thu, Mar 12, 2015 at 2:07 AM, Shawn Landden > wrote: > > On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers wrote: > >> > >> On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden > >> wrote: > >> > Still use helper when Xen Dom0, to avoid duplicating

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Kay Sievers
On Thu, Mar 12, 2015 at 2:07 AM, Shawn Landden wrote: > On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers wrote: >> >> On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden >> wrote: >> > Still use helper when Xen Dom0, to avoid duplicating some hairy code. >> > >> > I think the rbtree version was far more

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Kay Sievers
On Thu, Mar 12, 2015 at 2:12 AM, Shawn Landden wrote: > On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers wrote: >> >> On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden >> wrote: >> > Still use helper when Xen Dom0, to avoid duplicating some hairy code. >> > >> > I think the rbtree version was far more

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers wrote: > On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden > wrote: > > Still use helper when Xen Dom0, to avoid duplicating some hairy code. > > > > I think the rbtree version was far more understandable as > greedy_realloc0() > > is very messy to do co

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers wrote: > On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden > wrote: > > Still use helper when Xen Dom0, to avoid duplicating some hairy code. > > > > I think the rbtree version was far more understandable as > greedy_realloc0() > > is very messy to do co

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Kay Sievers
On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden wrote: > Still use helper when Xen Dom0, to avoid duplicating some hairy code. > > I think the rbtree version was far more understandable as greedy_realloc0() > is very messy to do correctly. > > Take fopenat() from lsof. > Add opendirat() We have th

[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. I think the rbtree version was far more understandable as greedy_realloc0() is very messy to do correctly. Take fopenat() from lsof. Add opendirat() Future: generate BootLoaderSpec files for other kernel install locations v5:

[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. I think the rbtree version was far more understandable as greedy_realloc0() is very messy to do correctly. Take fopenat() from lsof. Where is $BOOT? Shouldn't /boot/efi be a symlink to . (/boot) ? Debian defaults to $BOOT=/boo

[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. I think the rbtree version was far more understandable as greedy_realloc0() is very messy to do correctly. Take fopenat() from lsof. Future: generate BootLoaderSpec files for other kernel install locations v5: fix syscall inv