Re: [systemd-devel] [PATCH] swap: rework discard

2014-10-29 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Tue, 28.10.14 13:14, Lennart Poettering (lenn...@poettering.net) wrote: On Thu, 23.10.14 16:39, Lennart Poettering (lenn...@poettering.net) wrote: Heya, Hmm, I think the generator should already treat the option fields the same way

Re: [systemd-devel] [PATCH] swap: rework discard

2014-10-28 Thread Lennart Poettering
On Thu, 23.10.14 16:39, Lennart Poettering (lenn...@poettering.net) wrote: Heya, Hmm, I think the generator should already treat the option fields the same way as I want it to work in the long run, i.e. just read it from fstab and write it 1:1 into the unit's Options= string. I am hacking up

Re: [systemd-devel] [PATCH] swap: rework discard

2014-10-28 Thread Lennart Poettering
On Tue, 28.10.14 13:14, Lennart Poettering (lenn...@poettering.net) wrote: On Thu, 23.10.14 16:39, Lennart Poettering (lenn...@poettering.net) wrote: Heya, Hmm, I think the generator should already treat the option fields the same way as I want it to work in the long run, i.e. just read

[systemd-devel] [PATCH] swap: rework discard

2014-10-23 Thread Jan Synacek
Instead of a dedicated Discard option, use more general Options. When the swapon command learns -o, it will be possible to pass the value of Options as is. The code now assumes that the only possible value to Options is related to discard.

Re: [systemd-devel] [PATCH] swap: rework discard

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 14:58, Jan Synacek (jsyna...@redhat.com) wrote: -static int property_get_discard( +static int property_get_options( sd_bus *bus, const char *path, const char *interface, @@ -72,9 +72,9 @@ static int property_get_discard(