Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe you could an example with a negative value to the documentation and tests? Zbyszek Suggested by:

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe you could an example

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Tollef Fog Heen
]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp.

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 10:04:00PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Lennart Poettering
On Sun, 23.03.14 11:06, Dave Reisner (dreis...@archlinux.org) wrote: Also adds a few tests for the absolute cases of parse_timestamp. Suggested by: Mantas Mikulėnas graw...@gmail.com --- src/shared/time-util.c | 10 ++ src/test/test-time.c | 21 + 2 files