Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-05-21 Thread Colin Walters
On Wed, Apr 1, 2015, at 10:02 AM, Martin Pitt wrote: IMHO subvolumes, like hard disk partitions, are something that the administrator of a host should create deliberately only. Automatically created ones just create confusion about why the heck can't I remove that directory.. It's roughly

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-05-21 Thread Jóhann B. Guðmundsson
On 05/21/2015 03:19 PM, Colin Walters wrote: On Wed, Apr 1, 2015, at 10:02 AM, Martin Pitt wrote: IMHO subvolumes, like hard disk partitions, are something that the administrator of a host should create deliberately only. Automatically created ones just create confusion about why the heck

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 01.04.15 15:45, Jan Synacek (jsyna...@redhat.com) wrote: I am also against this since chrooting is an implementation detail of mock, nothing more, and the fact that mock's recursive deletion logic cannot handle removal of

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Lennart Poettering
On Wed, 01.04.15 21:04, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 04/01/2015 02:37 PM, Lennart Poettering wrote: Note that I intend to add more subvolume lines to tmpfiles even. For example, I am pretty sure /home should be created as subvolume if it doesn't exist already, and

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Lennart Poettering
On Thu, 02.04.15 08:59, Jan Synacek (jsyna...@redhat.com) wrote: think that systemd shouldn't create them where it doesn't make sense. I don't think that that's achievable with the current logic. Am I missing something? But why do you say when it doesn't make sense? Why do you think

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Thu, 02.04.15 08:59, Jan Synacek (jsyna...@redhat.com) wrote: think that systemd shouldn't create them where it doesn't make sense. I don't think that that's achievable with the current logic. Am I missing something? But why do you

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jóhann B. Guðmundsson
On 04/02/2015 08:31 AM, Lennart Poettering wrote: On Wed, 01.04.15 21:04, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 04/01/2015 02:37 PM, Lennart Poettering wrote: Note that I intend to add more subvolume lines to tmpfiles even. For example, I am pretty sure /home should be

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Lennart Poettering
On Thu, 02.04.15 14:33, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 04/02/2015 01:21 PM, Lennart Poettering wrote: Well, I disagree. And yeah, I still think that /var/lib/machines should be a subvolume, if it is not created manually as something else before. I hear no convincing

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Lennart Poettering
On Thu, 02.04.15 12:31, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 04/01/2015 02:37 PM, Lennart Poettering wrote: Note that I intend to add more subvolume lines to tmpfiles even. For example, I am pretty sure /home should be created as subvolume if it doesn't exist already, and

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jóhann B. Guðmundsson
On 04/02/2015 01:21 PM, Lennart Poettering wrote: Well, I disagree. And yeah, I still think that /var/lib/machines should be a subvolume, if it is not created manually as something else before. I hear no convincing case why it shouldn't be one. I argue that we should default to directory

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jóhann B. Guðmundsson
On 04/02/2015 03:48 PM, Lennart Poettering wrote: On Thu, 02.04.15 14:33, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 04/02/2015 01:21 PM, Lennart Poettering wrote: Well, I disagree. And yeah, I still think that /var/lib/machines should be a subvolume, if it is not created

[systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jan Synacek
Creating subvolumes in chrooted environments makes them undeletable and breaks mock. https://bugzilla.redhat.com/show_bug.cgi?id=1205564 Jan Synacek (1): tmpfiles: don't create subvolumes in chroot src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) --

[systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jan Synacek
--- src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 494fd1a..9280fd7 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -1099,9 +1099,15 @@ static int create_item(Item *i)

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jóhann B. Guðmundsson
On 04/01/2015 12:33 PM, Jan Synacek wrote: --- src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 494fd1a..9280fd7 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Lennart Poettering
On Wed, 01.04.15 12:40, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 494fd1a..9280fd7 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -1099,9 +1099,15 @@ static int create_item(Item *i) {

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Lennart Poettering
On Wed, 01.04.15 14:33, Jan Synacek (jsyna...@redhat.com) wrote: Creating subvolumes in chrooted environments makes them undeletable and breaks mock. Humm, I am not convinced that this is a good idea. The chroot environments are hardly undeletable, they just require you to delete them

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jóhann B. Guðmundsson
On 04/01/2015 01:04 PM, Lennart Poettering wrote: On Wed, 01.04.15 12:40, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 494fd1a..9280fd7 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -1099,9

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Lennart Poettering
On Wed, 01.04.15 15:45, Jan Synacek (jsyna...@redhat.com) wrote: I am also against this since chrooting is an implementation detail of mock, nothing more, and the fact that mock's recursive deletion logic cannot handle removal of subvolumes is not directly connected to the fact that mock

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 01.04.15 14:33, Jan Synacek (jsyna...@redhat.com) wrote: Creating subvolumes in chrooted environments makes them undeletable and breaks mock. Humm, I am not convinced that this is a good idea. The chroot environments are hardly

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Martin Pitt
Lennart Poettering [2015-04-01 15:48 +0200]: But why do you say when it doesn't make sense? Why do you think this doesn't make sense... As someone who has added hideous workarounds like | # old rootfs might contain btrfs subvolumes, remove them | subvols=$(btrfs subvolume list -o

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Lennart Poettering
On Wed, 01.04.15 16:02, Martin Pitt (martin.p...@ubuntu.com) wrote: Lennart Poettering [2015-04-01 15:48 +0200]: But why do you say when it doesn't make sense? Why do you think this doesn't make sense... As someone who has added hideous workarounds like | # old rootfs might contain

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jóhann B. Guðmundsson
On 04/01/2015 02:37 PM, Lennart Poettering wrote: Note that I intend to add more subvolume lines to tmpfiles even. For example, I am pretty sure /home should be created as subvolume if it doesn't exist already, and similar. I'm afraid that will still only work on a single host setup (