Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-18 Thread Koen Kooi
Op 7 jun. 2013, om 20:25 heeft Kay Sievers k...@vrfy.org het volgende geschreven: On Fri, Jun 7, 2013 at 3:27 PM, Sean McGovern gsean...@gmail.com wrote: Onboard network controllers are not always on PCI domain 0. +sysname = udev_device_get_sysname(names-pcidev); + +

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-18 Thread Kay Sievers
On Tue, Jun 18, 2013 at 3:19 PM, Koen Kooi k...@dominion.thruhere.net wrote: We only support domain 0, and ignore all other devices so far. What about non-PCI devices, like the netwerk controllers in embedded SoCs? I have no idea. This is so far all about PCI only, all the other parent buses

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-11 Thread Sean McGovern
On Monday, June 10, 2013, Kay Sievers k...@vrfy.org wrote: On Fri, Jun 7, 2013 at 11:46 PM, Sean McGovern gsean...@gmail.com wrote: This is definitely not a common case as almost all of the other Linux machines I have access to expose a network controller in domain 0. Yeah, I've only seen

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-10 Thread Kay Sievers
On Fri, Jun 7, 2013 at 11:46 PM, Sean McGovern gsean...@gmail.com wrote: This is definitely not a common case as almost all of the other Linux machines I have access to expose a network controller in domain 0. Yeah, I've only seen domains used on huge SGI machines. 256 PCI buses are quite a

[systemd-devel] [PATCH] udev: make net_id more robust

2013-06-07 Thread Sean McGovern
Onboard network controllers are not always on PCI domain 0. --- src/udev/udev-builtin-net_id.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/udev/udev-builtin-net_id.c b/src/udev/udev-builtin-net_id.c index 5719021..3e77f30 100644 ---

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-07 Thread Kay Sievers
On Fri, Jun 7, 2013 at 3:27 PM, Sean McGovern gsean...@gmail.com wrote: Onboard network controllers are not always on PCI domain 0. +sysname = udev_device_get_sysname(names-pcidev); + +if(!sysname) +return -ENOENT; + +if(!strlen(sysname)) +

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-07 Thread Sean McGovern
@lists.freedesktop.org Subject: Re: [systemd-devel] [PATCH] udev: make net_id more robust Sent: Jun 7, 2013 14:25 On Fri, Jun 7, 2013 at 3:27 PM, Sean McGovern gsean...@gmail.com wrote: Onboard network controllers are not always on PCI domain 0. +sysname = udev_device_get_sysname(names-pcidev

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-07 Thread Kay Sievers
On Fri, Jun 7, 2013 at 10:58 PM, Sean McGovern gsean...@gmail.com wrote: Ignore this patch then -- I can't change the PCI geography of my older G4 Mac Mini, and without this patch predictable interface naming does not work for it. I'll just keep it locally. Maybe we can add support for it,

Re: [systemd-devel] [PATCH] udev: make net_id more robust

2013-06-07 Thread Sean McGovern
: systemd-devel@lists.freedesktop.org Subject: Re: [systemd-devel] [PATCH] udev: make net_id more robust Sent: Jun 7, 2013 17:20 On Fri, Jun 7, 2013 at 10:58 PM, Sean McGovern gsean...@gmail.com wrote: Ignore this patch then -- I can't change the PCI geography of my older G4 Mac Mini, and without