Re: [systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Josh Triplett
On Wed, Mar 12, 2014 at 12:49:08AM +0100, Lennart Poettering wrote: Can you turn this into an inline function please? If it's that simple it sounds better to just make it an inline function in the .h file, instead of the .c file... Sure. Mind if I do that as a two-patch series? I prefer to

Re: [systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 18:33, Josh Triplett (j...@joshtriplett.org) wrote: On Wed, Mar 12, 2014 at 12:49:08AM +0100, Lennart Poettering wrote: Can you turn this into an inline function please? If it's that simple it sounds better to just make it an inline function in the .h file, instead of

Re: [systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 16:45, Josh Triplett (j...@joshtriplett.org) wrote: Can you turn this into an inline function please? If it's that simple it sounds better to just make it an inline function in the .h file, instead of the .c file... This simplifies in_charset down to a one-liner, and allows for

[systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Josh Triplett
This simplifies in_charset down to a one-liner, and allows for possible optimizations of strspn in libc. --- src/shared/util.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index d28caae..82326df 100644 --- a/src/shared/util.c