[systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Patrik Flykt
Hi, This patch set implements a DHCPv4 client library named libsystemd-dhcp to be used with systemd-network. The code implements the DHCP protocol from the INIT state up to expiry, T1 and T2 timer setting, but does nothing in response to the IP address reacquisition T1 and T2 timers

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Greg KH
On Wed, Nov 13, 2013 at 11:22:28PM +0200, Patrik Flykt wrote: Hi, This patch set implements a DHCPv4 client library named libsystemd-dhcp to be used with systemd-network. Nice stuff. Where did this code come from, conman? If so, for some reason I thought that it would be easier to

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Marcel Holtmann
Hi Greg, This patch set implements a DHCPv4 client library named libsystemd-dhcp to be used with systemd-network. Nice stuff. Where did this code come from, conman? If so, for some reason I thought that it would be easier to make a library of the existing conman dhcp code and have both

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Patrik Flykt
Hi, On Thu, 2013-11-14 at 06:31 +0900, Greg KH wrote: Nice stuff. Where did this code come from, conman? If so, for some reason I thought that it would be easier to make a library of the existing conman dhcp code and have both projects use it instead of forking and having two

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Colin Walters
On Thu, 2013-11-14 at 06:49 +0900, Marcel Holtmann wrote: that is the long term plan. Once ConnMan is switching over to use libsystemd-bus and kdbus, we are switching over to using the systemd event loop instead of GLib main loop But I think the long term architecturally correct place for

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Marcel Holtmann
Hi Colin, that is the long term plan. Once ConnMan is switching over to use libsystemd-bus and kdbus, we are switching over to using the systemd event loop instead of GLib main loop But I think the long term architecturally correct place for the core system main loop is glibc, not

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Colin Walters
On Thu, 2013-11-14 at 07:25 +0900, Marcel Holtmann wrote: I am a bit lost on your concerns here. Our focus for ConnMan is libsystemd-bus and kdbus support. Yeah, sorry; I just kind of used your mail as a basis for the larger picture of sd_event as public API. And as a system daemon, I only

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Lennart Poettering
On Wed, 13.11.13 17:18, Colin Walters (walt...@verbum.org) wrote: On Thu, 2013-11-14 at 06:49 +0900, Marcel Holtmann wrote: that is the long term plan. Once ConnMan is switching over to use libsystemd-bus and kdbus, we are switching over to using the systemd event loop instead of GLib

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 14, 2013 at 12:47:24AM +0100, Lennart Poettering wrote: I doubt moving OpenJDK or Python to sd-event or something like it ever would make sense. (Do either even have any event loop? http://www.python.org/dev/peps/pep-3156/ Zbyszek ___

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Lennart Poettering
On Wed, 13.11.13 23:22, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: Hi, This patch set implements a DHCPv4 client library named libsystemd-dhcp to be used with systemd-network. The code implements the DHCP protocol from the INIT state up to expiry, T1 and T2 timer setting,

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Colin Walters
On Thu, 2013-11-14 at 00:47 +0100, Lennart Poettering wrote: I am pretty sure it makes sense to have domain-specific event loops. I am not convinced that it would even be possible to unify all event loop implementations into one. For example, GLib and and sd-event support priorization of