Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-08-14 Thread Lennart Poettering 
On Wed, 16.07.14 20:45, Jon Severinsson (j...@severinsson.net) wrote:

 
 onsdagen den 16 juli 2014 16:49:55 skrev  Lennart Poettering:
  On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote:
   From: Tollef Fog Heen tfh...@err.no
  
  If you really want to support systems without systemd installed, then I'd
  recommend placing this rules file in the systemd pacakge, so that it is
  gone if you uninstall systemd.
  
  That said, nothing of what the file does is in any way something that
  could break things on non-systemd systems, hence the whole excercise
  sounds pointless...
 
 The file still contains one RUN+=@rootlibexecdir@/systemd-sysctl ..., which 
 I don't think is desirable when systemd is installed but not running as PID 1 
 (which we also have to support).

The tool actually will work fine if you run it outside of
systemd. There's no dependency on systemd being PID 1 in that tool.

But I do see your point.

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Jon Severinsson 
From: Tollef Fog Heen tfh...@err.no

---
 rules/99-systemd.rules.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/99-systemd.rules.in b/rules/99-systemd.rules.in
index c3ef81b..df83a38 100644
--- a/rules/99-systemd.rules.in
+++ b/rules/99-systemd.rules.in
@@ -6,6 +6,7 @@
 #  (at your option) any later version.
 
 ACTION==remove, GOTO=systemd_end
+TEST!=/run/systemd/system, GOTO=systemd_end
 
 SUBSYSTEM==tty, 
KERNEL==tty[a-zA-Z]*|hvc*|xvc*|hvsi*|ttysclp*|sclp_line*|3270/tty[0-9]*, 
TAG+=systemd
 
-- 
2.0.1

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Kay Sievers 
On Wed, Jul 16, 2014 at 12:09 PM, Jon Severinsson j...@severinsson.net wrote:
 From: Tollef Fog Heen tfh...@err.no

 ---
  rules/99-systemd.rules.in | 1 +
  1 file changed, 1 insertion(+)

The file should not do any harm. If it does, we should check if
something needs to be fixed in a different way.

This patch looks like distro material who decide to support that.
Systemd does not want to support any such setups with the upstream
code base.

Thanks,
Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Martin Pitt 
Jon Severinsson [2014-07-16 12:09 +0200]:
  ACTION==remove, GOTO=systemd_end
 +TEST!=/run/systemd/system, GOTO=systemd_end

I'm fairly sure that this is obsolete. Can you please test without
this?

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread Jon Severinsson 
onsdagen den 16 juli 2014 16:49:55 skrev  Lennart Poettering:
 On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote:
  From: Tollef Fog Heen tfh...@err.no
 
 If you really want to support systems without systemd installed, then I'd
 recommend placing this rules file in the systemd pacakge, so that it is
 gone if you uninstall systemd.
 
 That said, nothing of what the file does is in any way something that
 could break things on non-systemd systems, hence the whole excercise
 sounds pointless...

The file still contains one RUN+=@rootlibexecdir@/systemd-sysctl ..., which 
I don't think is desirable when systemd is installed but not running as PID 1 
(which we also have to support).
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-07-16 Thread microcai 
在 2014年7月16日 星期三 20:45:56，Jon Severinsson 写道：
 The file still contains one RUN+=@rootlibexecdir@/systemd-sysctl ...,
 which  I don't think is desirable when systemd is installed but not running
 as PID 1 (which we also have to support).

support for the sake of support is a bad syndrom. 
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel