Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tom Gundersen
On Tue, Mar 24, 2015 at 8:51 PM, Tobias Hunger wrote: > I won't promise anything, but I'll give it a try later tonight. Thanks! > It is a bit frightening under what kind of attention you people have to > work: Even this tiny patch made it onto phoronix and I just got my first > flame about ruini

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tobias Hunger
I won't promise anything, but I'll give it a try later tonight. It is a bit frightening under what kind of attention you people have to work: Even this tiny patch made it onto phoronix and I just got my first flame about ruining Linux. ___ systemd-devel

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tom Gundersen
On Tue, Mar 24, 2015 at 5:53 PM, Tobias Hunger wrote: > Hi Tom, > > no, root=tmpfs rootfstype=tmpfs does *not* work without my patch. I > had thought it should, too, and I did try. > > fstab-generator was silently ignoring root= since "tmpfs" is not a > device. So no mount unit for /sysroot... > >

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tobias Hunger
Hi Tom, no, root=tmpfs rootfstype=tmpfs does *not* work without my patch. I had thought it should, too, and I did try. fstab-generator was silently ignoring root= since "tmpfs" is not a device. So no mount unit for /sysroot... Since fstab-generator did evaluate mount.usr* which did point to a re

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Vasiliy Tolstov
For overlayfs you need to check overlayfs and overlay. 24 марта 2015 г. 1:52 пользователь "Tobias Hunger" написал: > This allows for stateless systems. > --- > src/fstab-generator/fstab-generator.c | 21 + > src/shared/util.c | 30 +

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Andrei Borzenkov
On Tue, Mar 24, 2015 at 6:39 PM, Tom Gundersen wrote: > Hi Tobias and Zbigniew, > > This already went in, but I was just looking at it again. > > Is there any reason the kernel commandline handling must be treated > differently here than the fstab handling? We already support > deviceless mounts (

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tom Gundersen
Hi Tobias and Zbigniew, This already went in, but I was just looking at it again. Is there any reason the kernel commandline handling must be treated differently here than the fstab handling? We already support deviceless mounts (obviously) when specified in fstab without the need for any whiteli

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 24, 2015 at 12:48:15PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Mar 24, 2015 at 10:59:20AM +0100, Tobias Hunger wrote: > > On Tue, Mar 24, 2015 at 5:12 AM, Zbigniew Jędrzejewski-Szmek > > wrote: > > > This wouldn't work if fstype was NULL. We also have a list of network > >

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 24, 2015 at 10:59:20AM +0100, Tobias Hunger wrote: > On Tue, Mar 24, 2015 at 5:12 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > This wouldn't work if fstype was NULL. We also have a list of network > > filesystems, > > whic I assume don't require a device, and we can consult this list

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tobias Hunger
On Tue, Mar 24, 2015 at 5:12 AM, Zbigniew Jędrzejewski-Szmek wrote: > This wouldn't work if fstype was NULL. We also have a list of network > filesystems, > whic I assume don't require a device, and we can consult this list instead of > including > it here. I pushed the patch with those changes.

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 24, 2015 at 12:52:59AM +0100, Tobias Hunger wrote: > This allows for stateless systems. > --- > src/fstab-generator/fstab-generator.c | 21 + > src/shared/util.c | 30 ++ > src/shared/util.h | 1 +

[systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-23 Thread Tobias Hunger
This allows for stateless systems. --- src/fstab-generator/fstab-generator.c | 21 + src/shared/util.c | 30 ++ src/shared/util.h | 1 + 3 files changed, 44 insertions(+), 8 deletions(-) diff --git a/src/fsta