Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2014-02-22 Thread Tom Gundersen
On Wed, Nov 13, 2013 at 3:58 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 12.11.13 05:49, Jan Engelhardt (jeng...@inai.de) wrote: Given a card that can do 100 Mbit/s, that would be about 12.5 MByte/s, but you cannot seriously expect me to use that value. Although it is quite

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2013-11-12 Thread David Timothy Strauss
On Tue, Nov 12, 2013 at 4:06 PM, Jan Engelhardt jeng...@inai.de wrote: In any case, even if the ethtool structures awkwardly specified the use of bytes, the user-visible part should be in bits, and this patch was to give an impetus. I won't commit the patch unless there's clarity that

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2013-11-12 Thread Lennart Poettering
On Tue, 12.11.13 05:49, Jan Engelhardt (jeng...@inai.de) wrote: Given a card that can do 100 Mbit/s, that would be about 12.5 MByte/s, but you cannot seriously expect me to use that value. Although it is quite compelling for 40 Gbit/s because that divides nicely to 5 GByte/sec, and we will be

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2013-11-12 Thread David Timothy Strauss
+1 on the unit in the value. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2013-11-11 Thread David Timothy Strauss
Is the code already assuming megabits in the speed variable?​ ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2013-11-11 Thread David Timothy Strauss
On Tue, Nov 12, 2013 at 3:27 PM, Jan Engelhardt jeng...@inai.de wrote: As far as I can see, ethtool-util.c in systemd merely passes that on to ethtool, and /usr/include/linux/ethtool.h says MBps in its comments. The capitalized B is generally bytes.

Re: [systemd-devel] [PATCH 1/2] udev: use bit as unit for network card speeds

2013-11-11 Thread Jan Engelhardt
On Tuesday 2013-11-12 06:34, David Timothy Strauss wrote: On Tue, Nov 12, 2013 at 3:27 PM, Jan Engelhardt jeng...@inai.de wrote: As far as I can see, ethtool-util.c in systemd merely passes that on to ethtool, and /usr/include/linux/ethtool.h says MBps in its comments.