On Fri, Jun 20, 2014 at 07:45:39PM +0200, Lennart Poettering wrote:
> On Thu, 19.06.14 14:52, Patrik Flykt (patrik.fl...@linux.intel.com) wrote:
>
> > On Wed, 2014-06-18 at 16:25 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > > On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
>
On Thu, 19.06.14 14:52, Patrik Flykt (patrik.fl...@linux.intel.com) wrote:
> On Wed, 2014-06-18 at 16:25 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
> > > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
> > > wro
On Thu, Jun 19, 2014 at 02:52:06PM +0300, Patrik Flykt wrote:
> On Wed, 2014-06-18 at 16:25 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
> > > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
> > > wrote:
> > > >> +
On Wed, 2014-06-18 at 16:25 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
> > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
> > wrote:
> > >> +if (client->fd > 0)
> > >> +safe_close(client->f
On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
> On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
> wrote:
> >> +if (client->fd > 0)
> >> +safe_close(client->fd);
> >> +client->fd = -1;
> > client->fd = safe_close(client->fd);
> >
On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
wrote:
>> +if (client->fd > 0)
>> +safe_close(client->fd);
>> +client->fd = -1;
> client->fd = safe_close(client->fd);
>
> That's what safe_close is for :)
And shouldn't the check be for client->fd >= 0?
On Fri, Jun 13, 2014 at 04:45:02PM +0300, Patrik Flykt wrote:
> Implement the initial functionality used for creating a DHCPv6 Solicit
> message containing the needed options and send it to the DHCPv6
> broadcast address. Increase the sent message count and ensure that
> the Solicit Initial Retrans
Implement the initial functionality used for creating a DHCPv6 Solicit
message containing the needed options and send it to the DHCPv6
broadcast address. Increase the sent message count and ensure that
the Solicit Initial Retransmission Time is strictly greater than
the Solicitation IRT as describe