Re: [systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2015-02-03 Thread Ivan Shapovalov
On 2015-02-03 at 23:05 +0100, Lennart Poettering wrote: > On Fri, 19.12.14 17:08, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > What happened to this patch series actually? I think only 1/4 was ever > commited, what about the other ones? Ivan, any chance you can rebase > the rest with Zbigniew

Re: [systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2015-02-03 Thread Lennart Poettering
On Fri, 19.12.14 17:08, Ivan Shapovalov (intelfx...@gmail.com) wrote: What happened to this patch series actually? I think only 1/4 was ever commited, what about the other ones? Ivan, any chance you can rebase the rest with Zbigniew's requested changes and post again? Thanks, Lennart > "Not fou

Re: [systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
This is a minor thing, but makes things easier, especially when using gitk or git format-patch: please keep the patch subject at around 80 characters (<=72 is best). I know we don't always to this, sometimes it just isn't possible, but in this case something like 'systemctl: report actual load err

[systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2014-12-19 Thread Ivan Shapovalov
"Not found" condition in find_paths_to_edit() has been made non-fatal because the error message in edit() ("Cannot find any units to edit") suggests that. Error messages in edit() themselves have been removed because - result of expand_names() is not checked anywhere else - an extra "cannot find a