Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-27 Thread Michal Sekletar
On Wed, Oct 08, 2014 at 04:54:59PM +0200, Lennart Poettering wrote: > On Wed, 08.10.14 16:49, Michal Sekletar (msekl...@redhat.com) wrote: > > > > > > Hmm, I think we should just do "need_umount = !in_container", like we > > > > > do for the other things like loopback detaching, dm detaching or >

Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-08 Thread Lennart Poettering
On Wed, 08.10.14 16:49, Michal Sekletar (msekl...@redhat.com) wrote: > > > > Hmm, I think we should just do "need_umount = !in_container", like we > > > > do for the other things like loopback detaching, dm detaching or > > > > swapoff. After all, if we run in a container we run in a mount > > > >

Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-08 Thread Michal Sekletar
On Wed, Oct 08, 2014 at 01:41:16PM +0200, Lennart Poettering wrote: > On Tue, 07.10.14 14:17, Michal Sekletar (msekl...@redhat.com) wrote: > > > On Thu, Oct 02, 2014 at 12:04:02PM +0200, Lennart Poettering wrote: > > > On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote: > > > > >

Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-08 Thread Lennart Poettering
On Tue, 07.10.14 14:17, Michal Sekletar (msekl...@redhat.com) wrote: > On Thu, Oct 02, 2014 at 12:04:02PM +0200, Lennart Poettering wrote: > > On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote: > > > > > #define FINALIZE_ATTEMPTS 50 > > > > > > @@ -207,7 +208,11 @@ int main(i

Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-07 Thread Michal Sekletar
On Thu, Oct 02, 2014 at 12:04:02PM +0200, Lennart Poettering wrote: > On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote: > > > #define FINALIZE_ATTEMPTS 50 > > > > @@ -207,7 +208,11 @@ int main(int argc, char *argv[]) { > > > > in_container = detect_container(NULL)

Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-02 Thread Lennart Poettering
On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote: > #define FINALIZE_ATTEMPTS 50 > > @@ -207,7 +208,11 @@ int main(int argc, char *argv[]) { > > in_container = detect_container(NULL) > 0; > > -need_umount = true; > +if (in_container && !have_effec

[systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-02 Thread Michal Sekletar
--- Makefile.am | 3 ++- src/core/shutdown.c | 7 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5033028..f8104bc 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1925,7 +1925,8 @@ systemd_shutdown_SOURCES = \ systemd_shutdown_LDADD =