Re: [systemd-devel] [PATCH 3/5] [uninitialized] No need to check if num is 0

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 11:20 AM, philippedesw...@gmail.com wrote: From: Philippe De Swert philippedesw...@gmail.com When num is 0 we jump to the error handling. However at that time r is not set yet by keyboard_fill so we most likely get a nonsensical error. However the num check is

[systemd-devel] [PATCH 3/5] [uninitialized] No need to check if num is 0

2014-09-10 Thread philippedeswert
From: Philippe De Swert philippedesw...@gmail.com When num is 0 we jump to the error handling. However at that time r is not set yet by keyboard_fill so we most likely get a nonsensical error. However the num check is not needed as the xkb_state_key_get_syms will not return negative values. From