Re: [systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

2015-05-27 Thread Daurnimator
On 28 May 2015 at 09:58, Filipe Brandenburger filbran...@google.com wrote: Though I'm not sure whether taking a strftime format as a command line argument is really a good idea... But I'll defer that to other reviewers. From working with lua, I recall that accepting arbitary strftime format

Re: [systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

2015-05-27 Thread Filipe Brandenburger
Hi, On Wed, May 27, 2015 at 3:40 PM, Charles Duffy char...@dyfis.net wrote: +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored -Wformat-nonliteral +time_len = strftime(buf, l, arg_time_format, curr_time); +if (time_len = 0) +return; +#pragma GCC

[systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

2015-05-27 Thread Charles Duffy
From: Charles Duffy chadu...@cisco.com --- src/cgtop/cgtop.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index 53e3a64..c3db62b 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c

Re: [systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

2015-05-27 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432766423-4578-5-git-send-email-charles%40dyfis.net -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing