Re: [systemd-devel] [PATCH 4/4] coredump: collect all /proc data useful for bug reporting

2014-11-24 Thread Jakub Filak
On Fri, 2014-11-21 at 21:14 +0100, Lennart Poettering wrote: On Wed, 19.11.14 11:01, Jakub Filak (jfi...@redhat.com) wrote: +/* Joins /proc/[pid]/fd/ and /proc/[pid]/fdinfo/ into the following lines: + * + * 0:/dev/pts/23 + * pos:0 + * flags: 012 + * 1:/dev/pts/23 + *

Re: [systemd-devel] [PATCH 4/4] coredump: collect all /proc data useful for bug reporting

2014-11-24 Thread Lennart Poettering
On Mon, 24.11.14 11:01, Jakub Filak (jfi...@redhat.com) wrote: char fd_name[sizeof(/proc/)-1 + DECIMAL_STR_MAX(pid_t) + sizeof(/fd/)-1 + DECIMAL_STR_MAX(int) + 1]; OK, I thought systemd prefers alloca(). I was inspired by procfs_file_alloca(). Well, this is a pseudo-function

Re: [systemd-devel] [PATCH 4/4] coredump: collect all /proc data useful for bug reporting

2014-11-21 Thread Lennart Poettering
On Wed, 19.11.14 11:01, Jakub Filak (jfi...@redhat.com) wrote: +/* Joins /proc/[pid]/fd/ and /proc/[pid]/fdinfo/ into the following lines: + * + * 0:/dev/pts/23 + * pos:0 + * flags: 012 + * 1:/dev/pts/23 + * pos:0 + * flags: 012 + * 2:/dev/pts/23 Hmm, I'd prefer a

[systemd-devel] [PATCH 4/4] coredump: collect all /proc data useful for bug reporting

2014-11-19 Thread Jakub Filak
/proc/[pid]: - status - maps - limits - cgroup - cwd - root - environ - fd/ fdinfo/ joined in open_fds --- src/journal/coredump.c | 137 - 1 file changed, 135 insertions(+), 2 deletions(-) diff --git a/src/journal/coredump.c