Re: [systemd-devel] [PATCH 7/8] timesyncd: don't reset polling interval when reselecting server

2014-09-02 Thread Miroslav Lichvar 
On Fri, Aug 29, 2014 at 06:38:49PM +0200, Kay Sievers wrote:
 On Wed, Aug 27, 2014 at 4:47 PM, Miroslav Lichvar mlich...@redhat.com wrote:
  ---
   src/timesync/timesyncd-manager.c | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)
 
 It did not apply without the earlier patch and in systemd we try to
 avoid using ! to test integers for 0. Added the fix.

Hm, I don't see this in the current git.

-- 
Miroslav Lichvar
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 7/8] timesyncd: don't reset polling interval when reselecting server

2014-09-02 Thread Kay Sievers 
On Tue, Sep 2, 2014 at 1:21 PM, Miroslav Lichvar mlich...@redhat.com wrote:
 On Fri, Aug 29, 2014 at 06:38:49PM +0200, Kay Sievers wrote:
 On Wed, Aug 27, 2014 at 4:47 PM, Miroslav Lichvar mlich...@redhat.com 
 wrote:
  ---
   src/timesync/timesyncd-manager.c | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)

 It did not apply without the earlier patch and in systemd we try to
 avoid using ! to test integers for 0. Added the fix.

 Hm, I don't see this in the current git.

Seems I never pushed it, sorry.

Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 7/8] timesyncd: don't reset polling interval when reselecting server

2014-08-29 Thread Kay Sievers 
On Wed, Aug 27, 2014 at 4:47 PM, Miroslav Lichvar mlich...@redhat.com wrote:
 ---
  src/timesync/timesyncd-manager.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

It did not apply without the earlier patch and in systemd we try to
avoid using ! to test integers for 0. Added the fix.

Thanks,
Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 7/8] timesyncd: don't reset polling interval when reselecting server

2014-08-27 Thread Miroslav Lichvar 
---
 src/timesync/timesyncd-manager.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c
index 9f12149..d1f77a8 100644
--- a/src/timesync/timesyncd-manager.c
+++ b/src/timesync/timesyncd-manager.c
@@ -735,7 +735,8 @@ static int manager_begin(Manager *m) {
 assert_return(m-current_server_address, -EHOSTUNREACH);
 
 m-missed_replies = NTP_MAX_MISSED_REPLIES;
-m-poll_interval_usec = NTP_POLL_INTERVAL_MIN_SEC * USEC_PER_SEC;
+if (!m-poll_interval_usec)
+m-poll_interval_usec = NTP_POLL_INTERVAL_MIN_SEC * 
USEC_PER_SEC;
 
 server_address_pretty(m-current_server_address, pretty);
 log_info(Using NTP server %s (%s)., strna(pretty), 
m-current_server_name-string);
-- 
1.9.3

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel