Re: [systemd-devel] [PATCH 8/9] Add man page and references to it.

2015-02-17 Thread Didier Roche

Le 14/02/2015 17:58, Zbigniew Jędrzejewski-Szmek a écrit :

On Thu, Feb 05, 2015 at 06:11:24PM +0100, Didier Roche wrote:

Thanks for the suggestions, all applied!



+
+paraThe first time it connects to plymouth, a request
+to grab Control+C keypresses is sent, as well as a text message.
+When the cancel key is pressed, all running fscks are terminated.
+It will also cancel any new connected fsck for the lifetime of
+filenamesystemd-fsckd/filename./para

paracommandsystemd-fsckd/ will instruct plymouth to grab
Control+C keypresses. When the key is pressed, running checks will be
terminated. It will also cancel any newly connected fsck instances for
the lifetime of filenamesystemd-fsckd/filename./para

This raises an intereseting question. IIUC, fsckd will exit on idle
after 30s, losing the information that ^C was pressed. Shouldn't
the exit-on-idle be raised to something bigger like 5 minutes, to
make this less likely to happen?


Good point, 30s of idleness (and so keeping ^C status) sounded enough to 
me at boot time (the more likely this will occur), most of fsck will 
chain anyway (first, the root one, and then, the other disks). Do you 
think about some cases with some .mount unit that are activated 
afterwards but still while plymouth is shown, like some encrypted /home 
partitions before the display manager shows up (didn't include the 
change, happy to do it though)?




+
+parafilenamesystemd-fsckd/filename passes the
+following messages to the theme via libplymouth:/para

Does it actually use libplymouth?


argh, sorry, didn't change it. Now done.


+
+  refsect1
+titleSee Also/title
+para
+  
citerefentryrefentrytitlesystemd/refentrytitlemanvolnum1/manvolnum/citerefentry,
+  
citerefentryrefentrytitlesystemd-fsck/refentrytitlemanvolnum8/manvolnum/citerefentry,
+  
citerefentryrefentrytitlefsck/refentrytitlemanvolnum8/manvolnum/citerefentry,
+  
citerefentryrefentrytitlesystemd-quotacheck.service/refentrytitlemanvolnum8/manvolnum/citerefentry,
Please add something like project='man-pages' (needs to be checked) to 
citerefentry,
so the links are correct in html version.
Seems to be project='man-pages' indeed. Done when referring to non 
systemd manpages (for the fsck* references) and same on 
man/systemd-f...@.service.xml


Cheers,
Didier

From 3f888284bb59ecaa8b8fba614161dfabb6a3463e Mon Sep 17 00:00:00 2001
From: Didier Roche didro...@ubuntu.com
Date: Mon, 26 Jan 2015 17:34:59 +0100
Subject: [PATCH 8/9] Add man page and references to it.

Add man page explaining the plymouth theme protocol, usage of the daemon
as well as the socket activation part.
Adapt existing fsck man page.
---
 Makefile-man.am|  12 +++
 man/systemd-f...@.service.xml  |  24 +++---
 man/systemd-fsckd.service.xml  | 162 +
 units/systemd-fsckd.service.in |   1 +
 units/systemd-fsckd.socket |   2 +-
 5 files changed, 189 insertions(+), 12 deletions(-)
 create mode 100644 man/systemd-fsckd.service.xml

diff --git a/Makefile-man.am b/Makefile-man.am
index 105853e..f2e13e8 100644
--- a/Makefile-man.am
+++ b/Makefile-man.am
@@ -67,6 +67,7 @@ MANPAGES += \
 	man/systemd-escape.1 \
 	man/systemd-firstboot.1 \
 	man/systemd-fsck@.service.8 \
+	man/systemd-fsckd.service.8 \
 	man/systemd-fstab-generator.8 \
 	man/systemd-getty-generator.8 \
 	man/systemd-gpt-auto-generator.8 \
@@ -210,6 +211,8 @@ MANPAGES_ALIAS += \
 	man/systemd-firstboot.service.1 \
 	man/systemd-fsck-root.service.8 \
 	man/systemd-fsck.8 \
+	man/systemd-fsckd.8 \
+	man/systemd-fsckd.socket.8 \
 	man/systemd-hibernate-resume.8 \
 	man/systemd-hibernate.service.8 \
 	man/systemd-hybrid-sleep.service.8 \
@@ -323,6 +326,8 @@ man/systemd-ask-password-wall.service.8: man/systemd-ask-password-console.servic
 man/systemd-firstboot.service.1: man/systemd-firstboot.1
 man/systemd-fsck-root.service.8: man/systemd-fsck@.service.8
 man/systemd-fsck.8: man/systemd-fsck@.service.8
+man/systemd-fsckd.8: man/systemd-fsckd.service.8
+man/systemd-fsckd.socket.8: man/systemd-fsckd.service.8
 man/systemd-hibernate-resume.8: man/systemd-hibernate-resume@.service.8
 man/systemd-hibernate.service.8: man/systemd-suspend.service.8
 man/systemd-hybrid-sleep.service.8: man/systemd-suspend.service.8
@@ -606,6 +611,12 @@ man/systemd-fsck-root.service.html: man/systemd-f...@.service.html
 man/systemd-fsck.html: man/systemd-f...@.service.html
 	$(html-alias)
 
+man/systemd-fsckd.html: man/systemd-fsckd.service.html
+	$(html-alias)
+
+man/systemd-fsckd.socket.html: man/systemd-fsckd.service.html
+	$(html-alias)
+
 man/systemd-hibernate-resume.html: man/systemd-hibernate-res...@.service.html
 	$(html-alias)
 
@@ -1732,6 +1743,7 @@ EXTRA_DIST += \
 	man/systemd-escape.xml \
 	man/systemd-firstboot.xml \
 	man/systemd-f...@.service.xml \
+	man/systemd-fsckd.service.xml \
 	man/systemd-fstab-generator.xml \
 	man/systemd-getty-generator.xml \
 	man/systemd-gpt-auto-generator.xml \
diff 

Re: [systemd-devel] [PATCH 8/9] Add man page and references to it.

2015-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 05, 2015 at 06:11:24PM +0100, Didier Roche wrote:
 

 From 2533acf15135d9db18fbd79e63de9a702e3859cc Mon Sep 17 00:00:00 2001
 From: Didier Roche didro...@ubuntu.com
 Date: Mon, 26 Jan 2015 17:34:59 +0100
 Subject: [PATCH 8/9] Add man page and references to it.
 
 Add man page explaining the plymouth theme protocol, usage of the daemon
 as well as the socket activation part.
 Adapt existing fsck man page.
 ---
  Makefile-man.am|  12 +++
  man/systemd-f...@.service.xml  |   6 +-
  man/systemd-fsckd.service.xml  | 165 
 +
  units/systemd-fsckd.service.in |   1 +
  units/systemd-fsckd.socket |   2 +-
  5 files changed, 183 insertions(+), 3 deletions(-)
  create mode 100644 man/systemd-fsckd.service.xml
 
 diff --git a/Makefile-man.am b/Makefile-man.am
 index 105853e..f2e13e8 100644
 --- a/Makefile-man.am
 +++ b/Makefile-man.am
 @@ -67,6 +67,7 @@ MANPAGES += \
   man/systemd-escape.1 \
   man/systemd-firstboot.1 \
   man/systemd-fsck@.service.8 \
 + man/systemd-fsckd.service.8 \
   man/systemd-fstab-generator.8 \
   man/systemd-getty-generator.8 \
   man/systemd-gpt-auto-generator.8 \
 @@ -210,6 +211,8 @@ MANPAGES_ALIAS += \
   man/systemd-firstboot.service.1 \
   man/systemd-fsck-root.service.8 \
   man/systemd-fsck.8 \
 + man/systemd-fsckd.8 \
 + man/systemd-fsckd.socket.8 \
   man/systemd-hibernate-resume.8 \
   man/systemd-hibernate.service.8 \
   man/systemd-hybrid-sleep.service.8 \
 @@ -323,6 +326,8 @@ man/systemd-ask-password-wall.service.8: 
 man/systemd-ask-password-console.servic
  man/systemd-firstboot.service.1: man/systemd-firstboot.1
  man/systemd-fsck-root.service.8: man/systemd-fsck@.service.8
  man/systemd-fsck.8: man/systemd-fsck@.service.8
 +man/systemd-fsckd.8: man/systemd-fsckd.service.8
 +man/systemd-fsckd.socket.8: man/systemd-fsckd.service.8
  man/systemd-hibernate-resume.8: man/systemd-hibernate-resume@.service.8
  man/systemd-hibernate.service.8: man/systemd-suspend.service.8
  man/systemd-hybrid-sleep.service.8: man/systemd-suspend.service.8
 @@ -606,6 +611,12 @@ man/systemd-fsck-root.service.html: 
 man/systemd-f...@.service.html
  man/systemd-fsck.html: man/systemd-f...@.service.html
   $(html-alias)
  
 +man/systemd-fsckd.html: man/systemd-fsckd.service.html
 + $(html-alias)
 +
 +man/systemd-fsckd.socket.html: man/systemd-fsckd.service.html
 + $(html-alias)
 +
  man/systemd-hibernate-resume.html: man/systemd-hibernate-res...@.service.html
   $(html-alias)
  
 @@ -1732,6 +1743,7 @@ EXTRA_DIST += \
   man/systemd-escape.xml \
   man/systemd-firstboot.xml \
   man/systemd-f...@.service.xml \
 + man/systemd-fsckd.service.xml \
   man/systemd-fstab-generator.xml \
   man/systemd-getty-generator.xml \
   man/systemd-gpt-auto-generator.xml \
 diff --git a/man/systemd-f...@.service.xml b/man/systemd-f...@.service.xml
 index ee66f37..d366712 100644
 --- a/man/systemd-f...@.service.xml
 +++ b/man/systemd-f...@.service.xml
 @@ -87,8 +87,9 @@
  check, number of mounts, unclean unmount, etc./para
  
  parafilenamesystemd-fsck/filename will forward
 -file system checking progress to the console. If a
 -file system check fails for a service without
 +file system checking progress to
 +filenamesystemd-fsckd.service/filename
 +socket. If a file system check fails for a service without
  optionnofail/option, emergency mode is activated,
  by isolating to
  filenameemergency.target/filename./para
 @@ -142,6 +143,7 @@
  para
  
 citerefentryrefentrytitlesystemd/refentrytitlemanvolnum1/manvolnum/citerefentry,
  
 citerefentryrefentrytitlefsck/refentrytitlemanvolnum8/manvolnum/citerefentry,
 +
 citerefentryrefentrytitlesystemd-fsckd.service/refentrytitlemanvolnum8/manvolnum/citerefentry,
  
 citerefentryrefentrytitlesystemd-quotacheck.service/refentrytitlemanvolnum8/manvolnum/citerefentry,
  
 citerefentryrefentrytitlefsck.btrfs/refentrytitlemanvolnum8/manvolnum/citerefentry,
  
 citerefentryrefentrytitlefsck.cramfs/refentrytitlemanvolnum8/manvolnum/citerefentry,
 diff --git a/man/systemd-fsckd.service.xml b/man/systemd-fsckd.service.xml
 new file mode 100644
 index 000..4a3b60d
 --- /dev/null
 +++ b/man/systemd-fsckd.service.xml
 @@ -0,0 +1,165 @@
 +?xml version=1.0?
 +!--*-nxml-*--
 +!DOCTYPE refentry PUBLIC -//OASIS//DTD DocBook XML V4.2//EN 
 http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd;
 +!--
 +  This file is part of systemd.
 +
 +  Copyright 2015 Canonical
 +
 +  systemd is free software; you can redistribute it and/or modify it
 +  under the terms of the GNU Lesser General Public License as 

[systemd-devel] [PATCH 8/9] Add man page and references to it.

2015-02-05 Thread Didier Roche


From 2533acf15135d9db18fbd79e63de9a702e3859cc Mon Sep 17 00:00:00 2001
From: Didier Roche didro...@ubuntu.com
Date: Mon, 26 Jan 2015 17:34:59 +0100
Subject: [PATCH 8/9] Add man page and references to it.

Add man page explaining the plymouth theme protocol, usage of the daemon
as well as the socket activation part.
Adapt existing fsck man page.
---
 Makefile-man.am|  12 +++
 man/systemd-f...@.service.xml  |   6 +-
 man/systemd-fsckd.service.xml  | 165 +
 units/systemd-fsckd.service.in |   1 +
 units/systemd-fsckd.socket |   2 +-
 5 files changed, 183 insertions(+), 3 deletions(-)
 create mode 100644 man/systemd-fsckd.service.xml

diff --git a/Makefile-man.am b/Makefile-man.am
index 105853e..f2e13e8 100644
--- a/Makefile-man.am
+++ b/Makefile-man.am
@@ -67,6 +67,7 @@ MANPAGES += \
 	man/systemd-escape.1 \
 	man/systemd-firstboot.1 \
 	man/systemd-fsck@.service.8 \
+	man/systemd-fsckd.service.8 \
 	man/systemd-fstab-generator.8 \
 	man/systemd-getty-generator.8 \
 	man/systemd-gpt-auto-generator.8 \
@@ -210,6 +211,8 @@ MANPAGES_ALIAS += \
 	man/systemd-firstboot.service.1 \
 	man/systemd-fsck-root.service.8 \
 	man/systemd-fsck.8 \
+	man/systemd-fsckd.8 \
+	man/systemd-fsckd.socket.8 \
 	man/systemd-hibernate-resume.8 \
 	man/systemd-hibernate.service.8 \
 	man/systemd-hybrid-sleep.service.8 \
@@ -323,6 +326,8 @@ man/systemd-ask-password-wall.service.8: man/systemd-ask-password-console.servic
 man/systemd-firstboot.service.1: man/systemd-firstboot.1
 man/systemd-fsck-root.service.8: man/systemd-fsck@.service.8
 man/systemd-fsck.8: man/systemd-fsck@.service.8
+man/systemd-fsckd.8: man/systemd-fsckd.service.8
+man/systemd-fsckd.socket.8: man/systemd-fsckd.service.8
 man/systemd-hibernate-resume.8: man/systemd-hibernate-resume@.service.8
 man/systemd-hibernate.service.8: man/systemd-suspend.service.8
 man/systemd-hybrid-sleep.service.8: man/systemd-suspend.service.8
@@ -606,6 +611,12 @@ man/systemd-fsck-root.service.html: man/systemd-f...@.service.html
 man/systemd-fsck.html: man/systemd-f...@.service.html
 	$(html-alias)
 
+man/systemd-fsckd.html: man/systemd-fsckd.service.html
+	$(html-alias)
+
+man/systemd-fsckd.socket.html: man/systemd-fsckd.service.html
+	$(html-alias)
+
 man/systemd-hibernate-resume.html: man/systemd-hibernate-res...@.service.html
 	$(html-alias)
 
@@ -1732,6 +1743,7 @@ EXTRA_DIST += \
 	man/systemd-escape.xml \
 	man/systemd-firstboot.xml \
 	man/systemd-f...@.service.xml \
+	man/systemd-fsckd.service.xml \
 	man/systemd-fstab-generator.xml \
 	man/systemd-getty-generator.xml \
 	man/systemd-gpt-auto-generator.xml \
diff --git a/man/systemd-f...@.service.xml b/man/systemd-f...@.service.xml
index ee66f37..d366712 100644
--- a/man/systemd-f...@.service.xml
+++ b/man/systemd-f...@.service.xml
@@ -87,8 +87,9 @@
 check, number of mounts, unclean unmount, etc./para
 
 parafilenamesystemd-fsck/filename will forward
-file system checking progress to the console. If a
-file system check fails for a service without
+file system checking progress to
+filenamesystemd-fsckd.service/filename
+socket. If a file system check fails for a service without
 optionnofail/option, emergency mode is activated,
 by isolating to
 filenameemergency.target/filename./para
@@ -142,6 +143,7 @@
 para
 citerefentryrefentrytitlesystemd/refentrytitlemanvolnum1/manvolnum/citerefentry,
 citerefentryrefentrytitlefsck/refentrytitlemanvolnum8/manvolnum/citerefentry,
+citerefentryrefentrytitlesystemd-fsckd.service/refentrytitlemanvolnum8/manvolnum/citerefentry,
 citerefentryrefentrytitlesystemd-quotacheck.service/refentrytitlemanvolnum8/manvolnum/citerefentry,
 citerefentryrefentrytitlefsck.btrfs/refentrytitlemanvolnum8/manvolnum/citerefentry,
 citerefentryrefentrytitlefsck.cramfs/refentrytitlemanvolnum8/manvolnum/citerefentry,
diff --git a/man/systemd-fsckd.service.xml b/man/systemd-fsckd.service.xml
new file mode 100644
index 000..4a3b60d
--- /dev/null
+++ b/man/systemd-fsckd.service.xml
@@ -0,0 +1,165 @@
+?xml version=1.0?
+!--*-nxml-*--
+!DOCTYPE refentry PUBLIC -//OASIS//DTD DocBook XML V4.2//EN http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd;
+!--
+  This file is part of systemd.
+
+  Copyright 2015 Canonical
+
+  systemd is free software; you can redistribute it and/or modify it
+  under the terms of the GNU Lesser General Public License as published by
+  the Free Software Foundation; either version 2.1 of the License, or
+  (at your option) any later version.
+
+  systemd is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR