Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-12-01 Thread Lennart Poettering
On Mon, 24.11.14 15:21, David Herrmann (dh.herrm...@gmail.com) wrote: I now pushed something to -git, see: commit d4f5a1f47dbd04f26f2ddf951c97c4cb0ebbbe62 Author: David Herrmann dh.herrm...@gmail.com Date: Mon Nov 24 15:12:42 2014 +0100 localed: validate xkb keymaps

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-12-01 Thread Lennart Poettering
On Mon, 24.11.14 13:31, Jan Synacek (jsyna...@redhat.com) wrote: Lennart Poettering lenn...@poettering.net writes: On Fri, 14.11.14 12:42, Jan Synacek (jsyna...@redhat.com) wrote: +if (look_for == LAYOUTS) { +Set *s; +char *k; +

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-24 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Fri, 14.11.14 12:42, Jan Synacek (jsyna...@redhat.com) wrote: +if (look_for == LAYOUTS) { +Set *s; +char *k; +Iterator i; +/* XXX: Is there a better way to sort

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-24 Thread David Herrmann
Hi On Wed, Nov 19, 2014 at 9:41 AM, Jan Synacek jsyna...@redhat.com wrote: David Herrmann dh.herrm...@gmail.com writes: Hi On Fri, Nov 14, 2014 at 12:42 PM, Jan Synacek jsyna...@redhat.com wrote: Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-19 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Fri, Nov 14, 2014 at 12:42 PM, Jan Synacek jsyna...@redhat.com wrote: Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning

[systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Jan Synacek
Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning that the user doesn't want any particular variant for the respective layout. Variants are validated respectively to their

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Susant Sahani
On 11/14/2014 05:12 PM, Jan Synacek wrote: +int xkb_validate_keymaps(const char *model, + const char *layouts_arg, + const char *variants_arg, + const char *options_arg, + char **error) +{ '{'

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Susant Sahani
On 11/14/2014 05:12 PM, Jan Synacek wrote: +int xkb_keymap_get_components(X11Keymap *keymap) { +_cleanup_strv_free_ char **models = NULL, **options = NULL; +_cleanup_fclose_ FILE *f; +char line[LINE_MAX]; +enum KeymapComponent state = NONE; +size_t m = 0,

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Lennart Poettering
On Fri, 14.11.14 12:42, Jan Synacek (jsyna...@redhat.com) wrote: diff --git a/Makefile.am b/Makefile.am index 701666c..224582c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -772,6 +772,8 @@ libsystemd_shared_la_SOURCES = \ src/shared/time-util.h \ src/shared/locale-util.c \

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Ronny Chevalier
2014-11-14 12:42 GMT+01:00 Jan Synacek jsyna...@redhat.com: Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning that the user doesn't want any particular variant for the