Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Lennart Poettering
On Thu, 09.04.15 15:20, Michal Sekletar (msekl...@redhat.com) wrote: > +quotes = chars_intersect(service, SHELL_NEED_QUOTES); > + > +service_maybe_quoted = alloca(strlen(service) + 3); > +sprintf(service_maybe_quoted, "%s%s%s", quotes ? "'" : "", > service, quotes ? "'" : "

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 09, 2015 at 05:30:44PM +0200, Michal Sekletar wrote: > On Thu, Apr 09, 2015 at 03:24:54PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Apr 09, 2015 at 05:20:43PM +0200, Michal Sekletar wrote: > > > On Thu, Apr 09, 2015 at 02:44:38PM +, Zbigniew Jędrzejewski-Szmek > > > wro

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Michal Sekletar
On Thu, Apr 09, 2015 at 03:24:54PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Apr 09, 2015 at 05:20:43PM +0200, Michal Sekletar wrote: > > On Thu, Apr 09, 2015 at 02:44:38PM +, Zbigniew Jędrzejewski-Szmek wrote: > > > On Thu, Apr 09, 2015 at 04:35:53PM +0200, Michal Sekletar wrote: > >

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 09, 2015 at 05:20:43PM +0200, Michal Sekletar wrote: > On Thu, Apr 09, 2015 at 02:44:38PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Apr 09, 2015 at 04:35:53PM +0200, Michal Sekletar wrote: > > > On Thu, Apr 09, 2015 at 02:10:14PM +, Zbigniew Jędrzejewski-Szmek > > > wro

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Michal Sekletar
On Thu, Apr 09, 2015 at 02:44:38PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Apr 09, 2015 at 04:35:53PM +0200, Michal Sekletar wrote: > > On Thu, Apr 09, 2015 at 02:10:14PM +, Zbigniew Jędrzejewski-Szmek wrote: > > > On Thu, Apr 09, 2015 at 03:20:02PM +0200, Michal Sekletar wrote: > >

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 09, 2015 at 04:35:53PM +0200, Michal Sekletar wrote: > On Thu, Apr 09, 2015 at 02:10:14PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Apr 09, 2015 at 03:20:02PM +0200, Michal Sekletar wrote: > > > Users might have hard time figuring out why exactly their systemctl > > > reque

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Michal Sekletar
On Thu, Apr 09, 2015 at 02:10:14PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Apr 09, 2015 at 03:20:02PM +0200, Michal Sekletar wrote: > > Users might have hard time figuring out why exactly their systemctl request > > failed. If dbus job fails try to figure out more details about failure

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Djalal Harouni
On Thu, Apr 09, 2015 at 02:10:14PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Apr 09, 2015 at 03:20:02PM +0200, Michal Sekletar wrote: > > Users might have hard time figuring out why exactly their systemctl request > > failed. If dbus job fails try to figure out more details about failure

Re: [systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 09, 2015 at 03:20:02PM +0200, Michal Sekletar wrote: > Users might have hard time figuring out why exactly their systemctl request > failed. If dbus job fails try to figure out more details about failure by > examining Result property of the service. > > https://bugzilla.redhat.com/sho

[systemd-devel] [PATCH v2] log: be more verbose if dbus job fails

2015-04-09 Thread Michal Sekletar
Users might have hard time figuring out why exactly their systemctl request failed. If dbus job fails try to figure out more details about failure by examining Result property of the service. https://bugzilla.redhat.com/show_bug.cgi?id=1016680 --- src/libsystemd/sd-bus/bus-util.c | 41 +++