Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Lennart Poettering
On Fri, 15.08.14 02:17, Timofey Titovets (nefelim...@gmail.com) wrote: Applied! Thanks! > Signed-off-by: Timofey We don't do Signed-off-by on systemd, so I drop this when I pushed it. Thanks! Lennart -- Lennart Poettering, Red Hat ___ systemd-dev

Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
2014-08-15 2:00 GMT+03:00 Lennart Poettering : > On Fri, 15.08.14 01:43, Timofey Titovets (nefelim...@gmail.com) wrote: > >> >> +int fail_if_symlink(const char *unit, const char* where) { >> +assert(where); >> + >> +if (is_symlink(where) > 0) { >> +log_struct_unit(LO

Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Lennart Poettering
On Fri, 15.08.14 01:43, Timofey Titovets (nefelim...@gmail.com) wrote: > > +int fail_if_symlink(const char *unit, const char* where) { > +assert(where); > + > +if (is_symlink(where) > 0) { > +log_struct_unit(LOG_WARNING, > +unit, > +

[systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
Just complete TODO: * refuse mounting on symlinks I not add this TODO, but i think what it avoid potential security {and/or} bug issues v2 -> v3: Rebase on latest git Add message : Mount on symlink not allowed. if systemd try mounting entry from fstab on symlink, user get: $ systemctl status