Hello all,
I have a better fix now.
Martin Pitt [2015-05-19 8:59 +0200]:
- Boot, dev-foo.device becomes DEVICE_FOUND_MOUNT/tentative
- Do some more mounts from /dev/foo, e. g.
mkdir /tmp/etc /tmp/boot
mount -o bind /etc /tmp/etc
mount -o bind /boot /tmp/boot
(In
Patchset imported to github.
Pull request:
https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:20150519082346.GG3222%40piware.de
--
Generated by https://github.com/haraldh/mail2git
___
systemd-devel mailing list
On Tue, 19.05.15 10:23, Martin Pitt (martin.p...@ubuntu.com) wrote:
Hello all,
I have a better fix now.
So the problem is that this tentative → dead transition only works if
a device is referenced once, but causes overzealous unmounts if there
are more references.
Ah, indeed, that
Hey Lennart,
Lennart Poettering [2015-05-19 13:56 +0200]:
I have now committed a different fix now, that keeps counting of the
mount points in mount.c, instead of reaching over from device.c.
I only gave this light testing, would be cool if you could check if
this fixes things for you.
Martin Pitt [2015-05-19 15:17 +0200]:
My first hunch is that this is caused by calling
mount_load_proc_self_mountinfo() in mount_dispatch_io()
(src/core/mount.c:1682) *before* it goes through that new
SET_FOREACH() loop. That call will already see the removed mount and
call
On Tue, May 19, 2015 at 1:56 PM, Lennart Poettering
lenn...@poettering.net wrote:
On Tue, 19.05.15 10:23, Martin Pitt (martin.p...@ubuntu.com) wrote:
Hello all,
I have a better fix now.
So the problem is that this tentative → dead transition only works if
a device is referenced once, but
On Tue, 19.05.15 16:05, Martin Pitt (martin.p...@ubuntu.com) wrote:
That was a red herring. Turns out that your patch only added devices
to around which had mount-just_mounted || mount-just_changed,
which is obviously not the case for mounts which have been around for
a while (and these are
Hey Lennart,
Lennart Poettering [2015-05-19 17:23 +0200]:
Yes, we need to also record those which were just mounted or changed,
in case systemd rereads /proc/self/mountinfo at a time where two
mounts where created at once from the same device.
OK, as I suspected.
I now committed a change to
On Tue, 19.05.15 17:31, Martin Pitt (martin.p...@ubuntu.com) wrote:
Hey Lennart,
Lennart Poettering [2015-05-19 17:23 +0200]:
Yes, we need to also record those which were just mounted or changed,
in case systemd rereads /proc/self/mountinfo at a time where two
mounts where created at