Re: [systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-02 Thread Ramkumar Ramachandra
David Strauss wrote: Would it be possible, for testing purposes, to generate a machine ID on the fly if one is not present on disk? Hard, as /etc/machine-id is hardcoded in src/libsystemd-id128/sd-id128.c. I don't think it's worth the effort. Ram

Re: [systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-02 Thread Ramkumar Ramachandra
Zbigniew Jędrzejewski-Szmek wrote: I started munging your patch to apply it, but on second thought it is totally the wrong direction to take. The purpose of tests is to check if systemd will function after installation. And as mentioned elsewhere in the thread, journald will break badly, and

Re: [systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-02 Thread Michael Biebl
2012/12/2 Ramkumar Ramachandra artag...@gmail.com: Hm, you have a point. On Debian, /etc/machine-id is created when the systemd package is installed -- I'm not sure if it's in the source code or if it's a custom Debian patch. We run systemd-machine-id-setup in postinst. Michael [1]

Re: [systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-02 Thread Ramkumar Ramachandra
Hi Michael, Michael Biebl wrote: 2012/12/2 Ramkumar Ramachandra artag...@gmail.com: Hm, you have a point. On Debian, /etc/machine-id is created when the systemd package is installed -- I'm not sure if it's in the source code or if it's a custom Debian patch. We run systemd-machine-id-setup

[systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-01 Thread Ramkumar Ramachandra
The following tests fail if /etc/machine-id is not present: $ ./test-id128 random: a08ea8ed34594d4bbd953dd182ec86f9 Assertion 'sd_id128_get_machine(id) == 0' failed at src/test/test-id128.c:41, function main(). Aborting. [1]8017 abort (core dumped) ./test-id128 $ ./test-journal

Re: [systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-01 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 01, 2012 at 10:01:35AM +0530, Ramkumar Ramachandra wrote: The following tests fail if /etc/machine-id is not present: $ ./test-id128 random: a08ea8ed34594d4bbd953dd182ec86f9 Assertion 'sd_id128_get_machine(id) == 0' failed at src/test/test-id128.c:41, function main().

Re: [systemd-devel] [PATCH v4] Skip tests that depend on /etc/machine-id if it is not present

2012-12-01 Thread David Strauss
Would it be possible, for testing purposes, to generate a machine ID on the fly if one is not present on disk? On Sat, Dec 1, 2012 at 7:48 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sat, Dec 01, 2012 at 10:01:35AM +0530, Ramkumar Ramachandra wrote: The following tests fail if