Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-11-05 Thread Colin Guthrie
Hiya, Martin Pitt wrote on 28/10/14 11:18: @@ -275,30 +281,43 @@ _public_ struct udev_hwdb *udev_hwdb_new(struct udev *udev) { hwdb-refcount = 1; udev_list_init(udev, hwdb-properties_list, true); -hwdb-f = fopen(/etc/udev/hwdb.bin, re); +/* find

Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-11-05 Thread Martin Pitt
Hey Colin, Colin Guthrie [2014-11-05 15:30 +]: While it's a nice error message, I wonder if it should be reverted back to being dbg again for the initrd use case or perhaps some other mechanism could be used to suppress the error in that case? Oh indeed, I didn't consider that this would

Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-11-05 Thread Colin Guthrie
Martin Pitt wrote on 05/11/14 17:04: Hey Colin, Colin Guthrie [2014-11-05 15:30 +]: While it's a nice error message, I wonder if it should be reverted back to being dbg again for the initrd use case or perhaps some other mechanism could be used to suppress the error in that case? Oh

[systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-10-28 Thread Martin Pitt
Hello Lennart, Lennart Poettering [2014-10-28 11:31 +0100]: I'd prefer if you'd move the log message for the error into open_hwdb_bin() then, so that it is not the caller, but the callee which prints the error message in this case. That would then mean to move most of udev_hwdb_new() into

Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-10-28 Thread Lennart Poettering
On Tue, 28.10.14 12:18, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello Lennart, Checked with Kay, he's fine with this. Please commit! Thanks, Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list