Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-30 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1429895189.10988.22.camel%40gmail.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing list

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-27 Thread Lennart Poettering
On Fri, 24.04.15 21:39, Andrei Borzenkov (arvidj...@gmail.com) wrote: В Fri, 24 Apr 2015 20:19:33 +0200 Lennart Poettering lenn...@poettering.net пишет: On Fri, 24.04.15 20:46, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-24 at 19:13 +0200, Lennart Poettering wrote: On

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-27 Thread Ivan Shapovalov
On 2015-04-27 at 17:14 +0200, Lennart Poettering wrote: On Sat, 25.04.15 05:48, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-25 at 04:00 +0300, Ivan Shapovalov wrote: On 2015-04-24 at 16:04 +0200, Lennart Poettering wrote: [...] Actually, it really is about the

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-27 Thread Lennart Poettering
On Sat, 25.04.15 05:48, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-25 at 04:00 +0300, Ivan Shapovalov wrote: On 2015-04-24 at 16:04 +0200, Lennart Poettering wrote: [...] Actually, it really is about the UNIT_TRIGGERS dependencies only, since we don't do the

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-27 Thread Lennart Poettering
On Mon, 27.04.15 18:28, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-27 at 17:14 +0200, Lennart Poettering wrote: On Sat, 25.04.15 05:48, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-25 at 04:00 +0300, Ivan Shapovalov wrote: On 2015-04-24 at 16:04 +0200,

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Fri, 24.04.15 15:52, Lennart Poettering (lenn...@poettering.net) wrote: On Wed, 25.02.15 21:40, Ivan Shapovalov (intelfx...@gmail.com) wrote: Ivan, Because the order of coldplugging is not defined, we can reference a not-yet-coldplugged unit and read its state while it has not yet

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Ivan Shapovalov
not yet marked)On 2015-04-24 at 15:52 +0200, Lennart Poettering wrote: On Wed, 25.02.15 21:40, Ivan Shapovalov (intelfx...@gmail.com) wrote: Ivan, Because the order of coldplugging is not defined, we can reference a not-yet-coldplugged unit and read its state while it has not yet

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Fri, 24.04.15 16:04, Lennart Poettering (lenn...@poettering.net) wrote: On Fri, 24.04.15 15:52, Lennart Poettering (lenn...@poettering.net) wrote: before we coldplug a unit, we should coldplug all units it might trigger, which are those with a listed UNIT_TRIGGERS dependency, as well

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Wed, 25.02.15 21:40, Ivan Shapovalov (intelfx...@gmail.com) wrote: Ivan, Because the order of coldplugging is not defined, we can reference a not-yet-coldplugged unit and read its state while it has not yet been set to a meaningful value. This way, already active units may get started

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Fri, 24.04.15 15:52, Lennart Poettering (lenn...@poettering.net) wrote: before we coldplug a unit, we should coldplug all units it might trigger, which are those with a listed UNIT_TRIGGERS dependency, as well as all those that retroactively_start_dependencies() and

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Andrei Borzenkov
В Fri, 24 Apr 2015 20:19:33 +0200 Lennart Poettering lenn...@poettering.net пишет: On Fri, 24.04.15 20:46, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-24 at 19:13 +0200, Lennart Poettering wrote: On Fri, 24.04.15 20:06, Ivan Shapovalov (intelfx...@gmail.com) wrote:

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Fri, 24.04.15 20:46, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-24 at 19:13 +0200, Lennart Poettering wrote: On Fri, 24.04.15 20:06, Ivan Shapovalov (intelfx...@gmail.com) wrote: With this patch applied, on `systemctl daemon-reload` I get the following: Any

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Fri, 24.04.15 17:23, Ivan Shapovalov (intelfx...@gmail.com) wrote: I think I agree with this idea. I just didn't know how to handle potentially unbounded recursion. Maybe we can do something along these lines (pseudocode): while (any units left to coldplug) for (unit in hashmap)

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Ivan Shapovalov
On 2015-04-24 at 16:04 +0200, Lennart Poettering wrote: On Fri, 24.04.15 15:52, Lennart Poettering (lenn...@poettering.net) wrote: before we coldplug a unit, we should coldplug all units it might trigger, which are those with a listed UNIT_TRIGGERS dependency, as well as all those that

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Ivan Shapovalov
On 2015-04-25 at 04:00 +0300, Ivan Shapovalov wrote: On 2015-04-24 at 16:04 +0200, Lennart Poettering wrote: [...] Actually, it really is about the UNIT_TRIGGERS dependencies only, since we don't do the retroactive deps stuff at all when we are coldplugging, it's conditionalized in

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Lennart Poettering
On Fri, 24.04.15 20:06, Ivan Shapovalov (intelfx...@gmail.com) wrote: With this patch applied, on `systemctl daemon-reload` I get the following: Any chance you can do the same with debugging on? systemd-analyze set-log-level debug right before the daemon-reload? That should show the

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Ivan Shapovalov
On 2015-04-24 at 16:20 +0200, Lennart Poettering wrote: On Fri, 24.04.15 16:04, Lennart Poettering (lenn...@poettering.net) wrote: On Fri, 24.04.15 15:52, Lennart Poettering (lenn...@poettering.net ) wrote: before we coldplug a unit, we should coldplug all units it might

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-04-24 Thread Ivan Shapovalov
On 2015-04-24 at 20:19 +0200, Lennart Poettering wrote: On Fri, 24.04.15 20:46, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-24 at 19:13 +0200, Lennart Poettering wrote: On Fri, 24.04.15 20:06, Ivan Shapovalov (intelfx...@gmail.com) wrote: With this patch applied,

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-03-09 Thread Tom Gundersen
FTR, this has now been applied by Zbigniew. On Thu, Mar 5, 2015 at 7:07 PM, Ivan Shapovalov intelfx...@gmail.com wrote: On 2015-02-28 at 00:50 +0300, Ivan Shapovalov wrote: On 2015-02-27 at 22:25 +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-03-05 Thread Ivan Shapovalov
On 2015-02-28 at 00:50 +0300, Ivan Shapovalov wrote: On 2015-02-27 at 22:25 +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan Shapovalov wrote: Because the order of coldplugging is not defined, we can reference a not-yet-coldplugged unit and read its

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan Shapovalov wrote: Because the order of coldplugging is not defined, we can reference a not-yet-coldplugged unit and read its state while it has not yet been set to a meaningful value. This way, already active units may get started again. We

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-02-27 Thread Ivan Shapovalov
On 2015-02-27 at 22:25 +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan Shapovalov wrote: Because the order of coldplugging is not defined, we can reference a not-yet-coldplugged unit and read its state while it has not yet been set to a meaningful