On Mon, Apr 13, 2015 at 12:05 PM, Tomasz Bursztyka
wrote:
>>> +int manager_new(Manager **ret);
>>> +Manager *manager_free(Manager *m);
>>> +
>>> +DEFINE_TRIVIAL_CLEANUP_FUNC(Manager*, manager_free);
>>> +#define _cleanup_manager_free_ _cleanup_(manager_freep)
>>
>> We generally try to avoid this d
Hi Zbigniew,
+
+[Service]
+Restart=on-failure
+ExecStart=@rootlibexecdir@/systemd-proxy-discoveryd
+StandardOutput=null
What privileges does this daemon require? I'd guess it can run as normal
user at least... Since this is supposed to be executing untrusted javascript
code, let's lock it down
Hi Lennart,
+
+[Unit]
+Description=Proxy service
+DefaultDependencies=no
Hmm, should this really be an early-boot service? Can you explain?
That's a mistake indeed.
+Requires=dbus.socket
+After=dbus.socket
+Before=remote-fs.target
Which this dependency?
Took that quickly from pacrunner.s
Hi Tom,
+int manager_new(Manager **ret);
+Manager *manager_free(Manager *m);
+
+DEFINE_TRIVIAL_CLEANUP_FUNC(Manager*, manager_free);
+#define _cleanup_manager_free_ _cleanup_(manager_freep)
We generally try to avoid this define in internal code, and just use
_cleanup_(manager_freep) inline.
O
On Fri, Apr 10, 2015 at 03:17:38PM +0300, Tomasz Bursztyka wrote:
> +# This file is part of systemd.
> +#
> +# systemd is free software; you can redistribute it and/or modify it
> +# under the terms of the GNU Lesser General Public License as published by
> +# the Free Software Foundation; either v