Re: [systemd-devel] [RFC 14/25] shared/missing.h: check for missing __compar_fn_t typedef

2014-09-18 Thread David Herrmann
Hi

On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing  wrote:
> ---
>  src/shared/missing.h | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/shared/missing.h b/src/shared/missing.h
> index 55e61f6..be099c5 100644
> --- a/src/shared/missing.h
> +++ b/src/shared/missing.h
> @@ -147,6 +147,11 @@ static inline char *canonicalize_file_name(const char 
> *path) {
>})
>  #endif
>
> +#ifndef __COMPAR_FN_T
> +#define __COMPAR_FN_T
> +typedef int (*__compar_fn_t)(const void *, const void *);
> +#endif
> +

Why not simply define this in your libc? I mean, it doesn't add any
code, so seems totally legit to add.

Thanks
David

>  #ifdef __x86_64__
>  #  ifndef __NR_fanotify_init
>  #define __NR_fanotify_init 300
> --
> 2.1.0
>
> ___
> systemd-devel mailing list
> systemd-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [RFC 14/25] shared/missing.h: check for missing __compar_fn_t typedef

2014-09-18 Thread Emil Renner Berthing
---
 src/shared/missing.h | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/shared/missing.h b/src/shared/missing.h
index 55e61f6..be099c5 100644
--- a/src/shared/missing.h
+++ b/src/shared/missing.h
@@ -147,6 +147,11 @@ static inline char *canonicalize_file_name(const char 
*path) {
   })
 #endif
 
+#ifndef __COMPAR_FN_T
+#define __COMPAR_FN_T
+typedef int (*__compar_fn_t)(const void *, const void *);
+#endif
+
 #ifdef __x86_64__
 #  ifndef __NR_fanotify_init
 #define __NR_fanotify_init 300
-- 
2.1.0

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel