Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-09 Thread Damien Robert
From Lennart Poettering, Wed 08 Oct 2014 at 23:33:13 (+0200) : On Fri, 03.10.14 19:18, Damien Robert (damien.olivier.rob...@gmail.com) wrote: But this means it would only find the template, and the instance would have to come from somewhere else, but where? From the preset file? No,

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-09 Thread Lennart Poettering
On Thu, 09.10.14 11:42, Damien Robert (damien.olivier.rob...@gmail.com) wrote: From Lennart Poettering, Wed 08 Oct 2014 at 23:33:13 (+0200) : On Fri, 03.10.14 19:18, Damien Robert (damien.olivier.rob...@gmail.com) wrote: But this means it would only find the template, and the

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-09 Thread Damien Robert
From Lennart Poettering, Thu 09 Oct 2014 at 16:44:42 (+0200) : But this means it would only find the template, and the instance would have to come from somewhere else, but where? From the preset file? No, we enumerate the installed unit files, and then look them up in the

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-08 Thread Lennart Poettering
On Fri, 03.10.14 19:18, Damien Robert (damien.olivier.rob...@gmail.com) wrote: From Lennart Poettering, Thu 02 Oct 2014 at 16:48:19 (+0200) : Well, but from somewhere systemctl preset-all needs to be able to discover the bar string... How is that supposed to work? preset-all just

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-03 Thread Damien Robert
From Lennart Poettering, Thu 02 Oct 2014 at 17:42:36 (+0200) : Hence so far the idea was to look for the presets only in the dirs where we look for static data, but not for configuration. We can certainly revisit this though. This makes sense for system services, but for user services it is a

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-03 Thread Damien Robert
From Lennart Poettering, Thu 02 Oct 2014 at 17:32:07 (+0200) : Would it be possible for the .preset file to just specify foo@.service and then the code that actually enables it just process the DefaultInstance rule as normal? That should already work, no? Yes it works: in

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-03 Thread Damien Robert
From Lennart Poettering, Thu 02 Oct 2014 at 16:48:19 (+0200) : Well, but from somewhere systemctl preset-all needs to be able to discover the bar string... How is that supposed to work? preset-all just enumerates all unit files that are installed and enables/disables them according to the

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-03 Thread Damien Robert
From Damien Robert, Fri 03 Oct 2014 at 19:18:31 (+0200) : From the preset file? I agree that since the enable/disable directive denotes glob, they are not well suited for instances services. Maybe add a new directive: instanciate foo@bar.service uninstanciate foo@bar.service (the

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-02 Thread Lennart Poettering
On Thu, 25.09.14 19:45, Damien Robert (damien.olivier.robert+gm...@gmail.com) wrote: I really like the new preset directive, and I plan to use preset files to synchronise the services I launch at boot across my computers. However it is a bit cumbersome that preset files do not parse

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-02 Thread Damien Robert
From Lennart Poettering, Thu 02 Oct 2014 at 16:07:03 (+0200) : How precisely would you envision this to work? I mean, so far systemctl preset foo@bar.service will precisely enable foo@bar.service That's exactly what I want; I have not tried systemctl preset foo@bar.service, but in 'systemctl

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-02 Thread Lennart Poettering
On Thu, 02.10.14 16:36, Damien Robert (damien.olivier.rob...@gmail.com) wrote: From Lennart Poettering, Thu 02 Oct 2014 at 16:07:03 (+0200) : How precisely would you envision this to work? I mean, so far systemctl preset foo@bar.service will precisely enable foo@bar.service That's

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-02 Thread Colin Guthrie
Lennart Poettering wrote on 02/10/14 15:48: On Thu, 02.10.14 16:36, Damien Robert (damien.olivier.rob...@gmail.com) wrote: From Lennart Poettering, Thu 02 Oct 2014 at 16:07:03 (+0200) : How precisely would you envision this to work? I mean, so far systemctl preset foo@bar.service will

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-02 Thread Lennart Poettering
On Thu, 02.10.14 16:28, Colin Guthrie (gm...@colin.guthr.ie) wrote: Well, but from somewhere systemctl preset-all needs to be able to discover the bar string... How is that supposed to work? preset-all just enumerates all unit files that are installed and enables/disables them

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-10-02 Thread Lennart Poettering
On Thu, 25.09.14 20:29, Damien Robert (damien.olivier.robert+gm...@gmail.com) wrote: Damien Robert wrote in message m01rcj$dhh$2...@ger.gmane.org: I really like the new preset directive, and I plan to use preset files to synchronise the services I launch at boot across my computers.

[systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Damien Robert
I really like the new preset directive, and I plan to use preset files to synchronise the services I launch at boot across my computers. However it is a bit cumbersome that preset files do not parse instanced services files. I could play with DefaultInstance in foobar@.service.d/ droplets and add

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Damien Robert
Damien Robert wrote in message m01rcj$dhh$2...@ger.gmane.org: I really like the new preset directive, and I plan to use preset files to synchronise the services I launch at boot across my computers. Also according to the man file systemd.preset and my test, while user systemd units are looked

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Sep 25, 2014 at 08:29:46PM +, Damien Robert wrote: Damien Robert wrote in message m01rcj$dhh$2...@ger.gmane.org: I really like the new preset directive, and I plan to use preset files to synchronise the services I launch at boot across my computers. Also according to the man

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Sep 25, 2014 at 07:45:23PM +, Damien Robert wrote: I really like the new preset directive, and I plan to use preset files to synchronise the services I launch at boot across my computers. However it is a bit cumbersome that preset files do not parse instanced services files. I

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Damien Robert
Zbigniew Jędrzejewski-Szmek wrote in message 20140925211702.gv29...@in.waw.pl: This seems to be a mis-design. I'm pretty sure we should allow users to set their own presets, so those directories underneath the home dir should be added. Ok great! I'll be happy to provide a patch but I have

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Sep 25, 2014 at 10:44:35PM +, Damien Robert wrote: Zbigniew Jędrzejewski-Szmek wrote in message 20140925211702.gv29...@in.waw.pl: This seems to be a mis-design. I'm pretty sure we should allow users to set their own presets, so those directories underneath the home dir should

Re: [systemd-devel] [feature request] allow instances in file.preset

2014-09-25 Thread Damien Robert
[Resending to the list since I was not posting through gmane but through gmail this time and my post was rejected because I was not subscribed to the list. Sorry for the spam] From Zbigniew Jędrzejewski-Szmek, Fri 26 Sep 2014 at 01:00:11 (+0200) : +