Re: [systemd-devel] [systemd-commits] 5 commits - configure.ac Makefile.am src/analyze src/bus-proxyd src/cgtop src/core src/delta src/journal src/journal-remote src/libsystemd src/libsystemd-network

2014-09-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 15, 2014 at 07:30:26AM -0700, Michal Schmidt wrote:
 commit f44541bc934c6e2b0219e9eeb17a13a09558
 Author: Michal Schmidt mschm...@redhat.com
 Date:   Fri Aug 15 16:33:03 2014 +0200
 
 build: colorize gcc only if on tty
 
 Rather than forcing gcc to always produce colorized error messages
 whether on tty or not, enable automatic colorization by ensuring
 GCC_COLORS is set to a non-empty string.
 
 Doing it this way removes the need for workarounds in ~/.emacs or
 ~/.vimrc for M-x compile or :make, respectively, to work.
Hi,
this idea was discussed and rejected before, because with this change
standard 'make -j8' does not produce color output anymore. So working
around this in the editor is a better option. Also, it only needs
to be done once, so is not such a huge problem.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [systemd-commits] 5 commits - configure.ac Makefile.am src/analyze src/bus-proxyd src/cgtop src/core src/delta src/journal src/journal-remote src/libsystemd src/libsystemd-network

2014-09-16 Thread Zbigniew Jędrzejewski-Szmek
[sorry for the double post]

On Mon, Sep 15, 2014 at 07:30:26AM -0700, Michal Schmidt wrote:
 commit f44541bc934c6e2b0219e9eeb17a13a09558
 Author: Michal Schmidt mschm...@redhat.com
 Date:   Fri Aug 15 16:33:03 2014 +0200
 
 build: colorize gcc only if on tty
 
 Rather than forcing gcc to always produce colorized error messages
 whether on tty or not, enable automatic colorization by ensuring
 GCC_COLORS is set to a non-empty string.
 
 Doing it this way removes the need for workarounds in ~/.emacs or
 ~/.vimrc for M-x compile or :make, respectively, to work.
Hi,
this idea was discussed and rejected before, because with this change
standard 'make -j8' does not produce color output anymore. So working
around this in the editor is a better option. Also, it only needs
to be done once, so is not such a huge problem.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [systemd-commits] 5 commits - configure.ac Makefile.am src/analyze src/bus-proxyd src/cgtop src/core src/delta src/journal src/journal-remote src/libsystemd src/libsystemd-network

2014-09-16 Thread Michal Schmidt
On 09/16/2014 12:07 PM, Zbigniew Jędrzejewski-Szmek wrote:
 Rather than forcing gcc to always produce colorized error messages
 whether on tty or not, enable automatic colorization by ensuring
 GCC_COLORS is set to a non-empty string.
 Hi,
 this idea was discussed and rejected before, because with this change
 standard 'make -j8' does not produce color output anymore.

Was the discussion on the mailing list? I could not find it.
The coloring with make -j8 works for me on Fedora and Debian. Is there
a deciding factor I am missing? Wouldn't the lack of colors in this case
be a bug in gcc and/or make?

Michal

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [systemd-commits] 5 commits - configure.ac Makefile.am src/analyze src/bus-proxyd src/cgtop src/core src/delta src/journal src/journal-remote src/libsystemd src/libsystemd-network

2014-09-16 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Sep 16, 2014 at 12:29:03PM +0200, Michal Schmidt wrote:
 On 09/16/2014 12:07 PM, Zbigniew Jędrzejewski-Szmek wrote:
  Rather than forcing gcc to always produce colorized error messages
  whether on tty or not, enable automatic colorization by ensuring
  GCC_COLORS is set to a non-empty string.
  Hi,
  this idea was discussed and rejected before, because with this change
  standard 'make -j8' does not produce color output anymore.
 
 Was the discussion on the mailing list? I could not find it.
 The coloring with make -j8 works for me on Fedora and Debian. Is there
 a deciding factor I am missing? Wouldn't the lack of colors in this case
 be a bug in gcc and/or make?
Maybe on IRC, don't rembember. I'll check again, maybe I have some local
settings which break color output.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel