Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-18 Thread Karel Zak
On Sat, Feb 16, 2013 at 05:40:18PM +0100, Kay Sievers wrote: On Sat, Feb 16, 2013 at 4:45 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Feb 13, 2013 at 05:39:54AM +0200, Zeeshan Ali (Khattak) wrote: +} else if (streq(name, SYSTEM_ID)) +

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 13, 2013 at 05:39:54AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This version 2 removes the bogus 'FS_' prefix from blkid property names. --- src/udev/udev-builtin-blkid.c | 13 - 1 file changed, 12 insertions(+), 1

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-16 Thread Kay Sievers
On Sat, Feb 16, 2013 at 4:45 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Feb 13, 2013 at 05:39:54AM +0200, Zeeshan Ali (Khattak) wrote: +} else if (streq(name, SYSTEM_ID)) +udev_builtin_add_property(dev, test, ID_FS_SYSTEM_ID, value); + +

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-16 Thread Zeeshan Ali (Khattak)
On Sat, Feb 16, 2013 at 5:45 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Feb 13, 2013 at 05:39:54AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This version 2 removes the bogus 'FS_' prefix from blkid property names. ---

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-16 Thread Zeeshan Ali (Khattak)
On Sat, Feb 16, 2013 at 8:04 PM, Kay Sievers k...@vrfy.org wrote: On Sat, Feb 16, 2013 at 5:52 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Sat, Feb 16, 2013 at 5:45 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Feb 13, 2013 at 05:39:54AM +0200, Zeeshan Ali

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-16 Thread Kay Sievers
On Sat, Feb 16, 2013 at 10:53 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Sat, Feb 16, 2013 at 8:04 PM, Kay Sievers k...@vrfy.org wrote: We just hex encode stuff that isn't ascii or valid utf8, udev just mangles some old values for compat reasons, new stuff should only use

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-15 Thread Zeeshan Ali (Khattak)
On Wed, Feb 13, 2013 at 5:39 AM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This version 2 removes the bogus 'FS_' prefix from blkid property names. --- FWIW, I have actually tested this patch on a Fedora18 VM. It works! -- Regards,

[systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-12 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org This version 2 removes the bogus 'FS_' prefix from blkid property names. --- src/udev/udev-builtin-blkid.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/udev/udev-builtin-blkid.c