Re: [systemd-devel] DefaultDependencies=false on scopes

2015-02-04 Thread Lennart Poettering
On Tue, 03.02.15 21:03, Brandon Philips (bran...@ifup.co) wrote:

 Hey Lennart-
 
 On Tue, Feb 3, 2015 at 10:32 AM, Brandon Philips bran...@ifup.co wrote:
  On Tue, Feb 3, 2015 at 10:20 AM, Lennart Poettering
  lenn...@poettering.net wrote:
  I have added DefaultDependencies= for you now:
 
  http://cgit.freedesktop.org/systemd/systemd/commit/?id=261420ba2a20305ad271b6f5f380aa74c5c9dd50
 
  Thank you. I will work on getting Docker fixed up to fix this annoying 
  behavior.
 
 So, is this the best way to tell if the systemd I am working with
 supports setting this property on a scope?
 https://github.com/philips/libcontainer/blob/systemd-default-dependencies-false/cgroups/systemd/apply_systemd.go#L74

Hmm, I figure I am not hipster enough to read this Go code...

But yeah, if you check for ReadOnlyProperty when putting together a
scope, that sounds like an OK check.

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] DefaultDependencies=false on scopes

2015-02-03 Thread Brandon Philips
Hey Lennart-

On Tue, Feb 3, 2015 at 10:32 AM, Brandon Philips bran...@ifup.co wrote:
 On Tue, Feb 3, 2015 at 10:20 AM, Lennart Poettering
 lenn...@poettering.net wrote:
 I have added DefaultDependencies= for you now:

 http://cgit.freedesktop.org/systemd/systemd/commit/?id=261420ba2a20305ad271b6f5f380aa74c5c9dd50

 Thank you. I will work on getting Docker fixed up to fix this annoying 
 behavior.

So, is this the best way to tell if the systemd I am working with
supports setting this property on a scope?
https://github.com/philips/libcontainer/blob/systemd-default-dependencies-false/cgroups/systemd/apply_systemd.go#L74

Essentially I am trying to create a scope and seeing if I get a
PropertyReadOnly, if I do I don't set it.

For reference the PR is: https://github.com/docker/libcontainer/pull/359

Thanks,

Brandon
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] DefaultDependencies=false on scopes

2015-02-03 Thread Lennart Poettering
On Mon, 15.12.14 17:44, Brandon Philips (bran...@ifup.co) wrote:

 Hello-
 
 How is a user supposed to disable DefaultDependencies on a scope? From
 the docs it seems like it should work:
 
 Unless DefaultDependencies=false is used, scope units will implicitly
 have dependencies of type Conflicts= and Before= on
 shutdown.target.

Well, currenlty not all our props are exposed for transient units
yet. Many are, but we were too lazy to add them all. If you need more
properties, then let me know, and we can add them.

I have added DefaultDependencies= for you now:

http://cgit.freedesktop.org/systemd/systemd/commit/?id=261420ba2a20305ad271b6f5f380aa74c5c9dd50

 But, in practice:
 
 systemd-run --scope --property=DefaultDependencies=false /usr/bin/sleep 
 5
 Unknown assignment DefaultDependencies=false.
 Failed to create message: Invalid argument

This works now.

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] DefaultDependencies=false on scopes

2015-02-03 Thread Brandon Philips
On Tue, Feb 3, 2015 at 10:20 AM, Lennart Poettering
lenn...@poettering.net wrote:
 I have added DefaultDependencies= for you now:

 http://cgit.freedesktop.org/systemd/systemd/commit/?id=261420ba2a20305ad271b6f5f380aa74c5c9dd50

Thank you. I will work on getting Docker fixed up to fix this annoying behavior.

Brandon
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] DefaultDependencies=false on scopes

2014-12-15 Thread Brandon Philips
Hello-

How is a user supposed to disable DefaultDependencies on a scope? From
the docs it seems like it should work:

Unless DefaultDependencies=false is used, scope units will implicitly
have dependencies of type Conflicts= and Before= on shutdown.target.

But, in practice:

systemd-run --scope --property=DefaultDependencies=false /usr/bin/sleep 5
Unknown assignment DefaultDependencies=false.
Failed to create message: Invalid argument

The root problem I am trying to fix is that it seems the docker daemon
uses DefaulDependencies for all of its scopes which means that the
containers get killed by systemd before the docker daemon is notified
to shutdown.

AFAICS, this would need to be added here:
http://cgit.freedesktop.org/systemd/systemd/tree/src/libsystemd/sd-bus/bus-util.c#n1319

Thanks,

Brandon
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel