Re: [systemd-devel] Hashmap iteration is too costly

2017-07-17 Thread vcaputo
On Mon, Jul 17, 2017 at 10:12:12AM +0200, Lennart Poettering wrote: > On Fri, 14.07.17 03:18, vcap...@pengaru.com (vcap...@pengaru.com) wrote: > > > The current hashmap iteration incurs at least one function call per > > iteration, and in my observations using gcc 6.3 w/-g -O2, it's two: > > > >

Re: [systemd-devel] Hashmap iteration is too costly

2017-07-17 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 17, 2017 at 10:12:12AM +0200, Lennart Poettering wrote: > On Fri, 14.07.17 03:18, vcap...@pengaru.com (vcap...@pengaru.com) wrote: > > > The current hashmap iteration incurs at least one function call per > > iteration, and in my observations using gcc 6.3 w/-g -O2, it's two: > > > >

Re: [systemd-devel] Hashmap iteration is too costly

2017-07-17 Thread Lennart Poettering
On Fri, 14.07.17 03:18, vcap...@pengaru.com (vcap...@pengaru.com) wrote: > The current hashmap iteration incurs at least one function call per > iteration, and in my observations using gcc 6.3 w/-g -O2, it's two: > > internal_hashmap_iterate() > hashmap_iterate_entry() > > for every element

[systemd-devel] Hashmap iteration is too costly

2017-07-14 Thread vcaputo
The current hashmap iteration incurs at least one function call per iteration, and in my observations using gcc 6.3 w/-g -O2, it's two: internal_hashmap_iterate() hashmap_iterate_entry() for every element in the hashmap. In profiles of `journalctl -b --no-pager` having multiple (50) log