Re: [systemd-devel] Inconsistencies in the systemd.mount documentation

2013-09-11 Thread Thomas Bächler
Am 11.09.2013 17:08, schrieb Lennart Poettering:
 Using FsckPassNo= as a way to add that dep sucks really, because the
 ordering it does is stupid and fsck can do the ordering internally
 anyway these days...

So, shouldn't systemd-fstab-generator omit that entirely, too? Instead,
every mount with pass!=0 should get the correct fsck dependency.

 Automatically adding deps to fsck for all mounts is wrong too, since
 only some block-based file systems need fsck and it would suck having to
 carry a whitelist for thos in systemd.

Fair enough.





signature.asc
Description: OpenPGP digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] Inconsistencies in the systemd.mount documentation

2013-09-11 Thread Lennart Poettering
On Wed, 11.09.13 20:04, Thomas Bächler (tho...@archlinux.org) wrote:

 Am 11.09.2013 17:08, schrieb Lennart Poettering:
  Using FsckPassNo= as a way to add that dep sucks really, because the
  ordering it does is stupid and fsck can do the ordering internally
  anyway these days...
 
 So, shouldn't systemd-fstab-generator omit that entirely, too? Instead,
 every mount with pass!=0 should get the correct fsck dependency.

Well, in classic fstab passno=0 means no fsck, passno!=0 means fsck. On
top of that the value of passno can be used to order things. We
honour those rules when we convert from fstab, and for that use
FsckPassNo=. That's why it is compat only... 

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] Inconsistencies in the systemd.mount documentation

2013-08-21 Thread Thomas Bächler
In the manpage for systemd.mount(5), the following section is included:

COMPATIBILITY OPTIONS
   The following option is also available in the [Mount] section,
but exists purely for compatibility reasons and should not be used in
newly written mount files.

   FsckPassNo=
   The pass number for the file system checking service for this
mount. See systemd.service(5) for more information on this setting.


However, if you omit the FsckPassNo= option from a mount unit, no
dependency upon the correct systemd-fsck@ instance is created. So in
fact, the option has a function.

I'm not sure if this is intended, but in my opinion,
DefaultDependencies=yes in a .mount unit should create that dependency,
not the presence of a compatibility options. Does anyone know more?



signature.asc
Description: OpenPGP digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel