Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Martin Pitt
Hey Olaf,

Olaf Hering [2015-10-16 14:21 +0200]:
> My copy of /usr/lib/udev/hwdb.d/60-keyboard.hwdb has (at least) three
> issues:
> 
> This advice fails, bugreporting is disabled, perhaps just for me?
> # If your changes are generally applicable, open a bug report on
> #   http://bugs.freedesktop.org/enter_bug.cgi?product=systemd

Thanks for pointing out! This should point to github issues now, I'll
adjust this with my next keymap PR (presumably one to fix your key).

> The wildcard does not work for me, but using /dev/input/event5 works.
> #   udevadm hwdb --update
> #   udevadm trigger /dev/input/eventXX
> # where /dev/input/eventXX is the keyboard in question. If in
> # doubt, simply use /dev/input/event* to reload all input rules.

Kay, is this supposed to work (and udevadm fixed for that)? If not,
this certainly does work:

  udevadm trigger --sysname-match=event*

> And finally, this new entry to let th 'Earth' icon start the web browser
> instead of sending XF86HomePage, which is ignored.
> 
> # HP ProBook 6555b, icon earth, sends home, should send www
> evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard:pnHPProBook6555b:*
>  KEYBOARD_KEY_b2=www

This looks similar to this already existing rule for this model:
# HDX9494nr
evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard*:pnHDX9494NR:pvr*
 KEYBOARD_KEY_b2=www# Fn+F3
 KEYBOARD_KEY_d8=!f23   # touchpad off
 KEYBOARD_KEY_d9=!f22   # touchpad on

Do you have touchpad on/off keys? Do they already work?

As for the new entry being ignored, is that still the case after "udevadm
control --reload", or just rebooting? (I've heard that this sometimes is
necessary). If so, can you please pastebin "udevadm info --export-db"
somewhere, so that we can verify the DMI names and whether the hwdb
entry actually matches?

Finally, which systemd version are you running? (The 60-keyboard.hwdb
syntax changed in 220).

Thanks,

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


signature.asc
Description: Digital signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Olaf Hering
My copy of /usr/lib/udev/hwdb.d/60-keyboard.hwdb has (at least) three
issues:

This advice fails, bugreporting is disabled, perhaps just for me?
# If your changes are generally applicable, open a bug report on
#   http://bugs.freedesktop.org/enter_bug.cgi?product=systemd


The wildcard does not work for me, but using /dev/input/event5 works.
#   udevadm hwdb --update
#   udevadm trigger /dev/input/eventXX
# where /dev/input/eventXX is the keyboard in question. If in
# doubt, simply use /dev/input/event* to reload all input rules.


And finally, this new entry to let th 'Earth' icon start the web browser
instead of sending XF86HomePage, which is ignored.

# HP ProBook 6555b, icon earth, sends home, should send www
evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard:pnHPProBook6555b:*
 KEYBOARD_KEY_b2=www


This is the output from evtest:
...
Testing ... (interrupt to exit)
Event: time 1444997900.742080, type 4 (EV_MSC), code 4 (MSC_SCAN), value 1c
Event: time 1444997900.742080, type 1 (EV_KEY), code 28 (KEY_ENTER), value 0
Event: time 1444997900.742080, -- SYN_REPORT 
Event: time 1444997901.811896, type 4 (EV_MSC), code 4 (MSC_SCAN), value b2
Event: time 1444997901.811896, type 1 (EV_KEY), code 172 (KEY_HOMEPAGE), value 1
Event: time 1444997901.811896, -- SYN_REPORT 
Event: time 1444997901.818859, type 4 (EV_MSC), code 4 (MSC_SCAN), value b2
Event: time 1444997901.818859, type 1 (EV_KEY), code 172 (KEY_HOMEPAGE), value 0
Event: time 1444997901.818859, -- SYN_REPORT 
Event: time 1444997902.143888, type 4 (EV_MSC), code 4 (MSC_SCAN), value b2
Event: time 1444997902.143888, type 1 (EV_KEY), code 172 (KEY_HOMEPAGE), value 1
Event: time 1444997902.143888, -- SYN_REPORT 
Event: time 1444997902.150824, type 4 (EV_MSC), code 4 (MSC_SCAN), value b2
Event: time 1444997902.150824, type 1 (EV_KEY), code 172 (KEY_HOMEPAGE), value 0
Event: time 1444997902.150824, -- SYN_REPORT 
Event: time 1444997903.703173, type 4 (EV_MSC), code 4 (MSC_SCAN), value 1d
Event: time 1444997903.703173, type 1 (EV_KEY), code 29 (KEY_LEFTCTRL), value 1
Event: time 1444997903.703173, -- SYN_REPORT 
Event: time 1444997905.50, type 4 (EV_MSC), code 4 (MSC_SCAN), value 2e
Event: time 1444997905.50, type 1 (EV_KEY), code 46 (KEY_C), value 1
Event: time 1444997905.50, -- SYN_REPORT 
...

Olaf
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Olaf Hering
Am 16.10.2015 um 14:56 schrieb Martin Pitt:
>> # HP ProBook 6555b, icon earth, sends home, should send www
>> evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard:pnHPProBook6555b:*
>>  KEYBOARD_KEY_b2=www
> 
> This looks similar to this already existing rule for this model:
> # HDX9494nr
> evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard*:pnHDX9494NR:pvr*
>  KEYBOARD_KEY_b2=www# Fn+F3
>  KEYBOARD_KEY_d8=!f23   # touchpad off
>  KEYBOARD_KEY_d9=!f22   # touchpad on
> 
> Do you have touchpad on/off keys? Do they already work?

No, there are no such keys.

> As for the new entry being ignored, is that still the case after "udevadm
> control --reload", or just rebooting? (I've heard that this sometimes is
> necessary). If so, can you please pastebin "udevadm info --export-db"
> somewhere, so that we can verify the DMI names and whether the hwdb
> entry actually matches?

http://pastebin.com/raw.php?i=Y5NJWJGF

Ignored means the desktop does nothing with XF86HomePage.

> Finally, which systemd version are you running? (The 60-keyboard.hwdb
> syntax changed in 220).

openSUSE Tumbleweed, currently at 224.

Olaf
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Martin Pitt
Hello Olaf,

Olaf Hering [2015-10-16 15:22 +0200]:
> I just noticed that there is a catch al, which looks very odd:
> 
> evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard*:pn*:pvr*

How does it look odd?

> Why would such a wildcard be correct?

As inconsistent as scan code assignments are between different
vendors, the big ones at least sem to have some internal consistency,
like HP, the "ThinkPad Extra Buttons", or the "Acer WMI hotkeys". We
just found over time that a large number of different HP models all
have the same keymap and it seems logical to factor out the common
keys and then just add a few model specific adjustments.

The common map does not set b2 BTW, so disabling it won't change
anything.

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Olaf Hering
Am 16.10.2015 um 14:56 schrieb Martin Pitt:
> This looks similar to this already existing rule for this model:

I just noticed that there is a catch al, which looks very odd:


evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard*:pn*:pvr*

Why would such a wildcard be correct? Guess I will disable that part
and see what the hardware actually provides...

Olaf
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Martin Pitt
Olaf Hering [2015-10-16 15:14 +0200]:
> > As for the new entry being ignored, is that still the case after "udevadm
> > control --reload", or just rebooting? (I've heard that this sometimes is
> > necessary). If so, can you please pastebin "udevadm info --export-db"
> > somewhere, so that we can verify the DMI names and whether the hwdb
> > entry actually matches?
> 
> http://pastebin.com/raw.php?i=Y5NJWJGF

OK, so that has

P: /devices/platform/i8042/serio0/input/input4/event5
[...]
E: KEYBOARD_KEY_b2=www

which means that your hwdb match worked. Can you please copy the
output of

  udevadm test-builtin keyboard 
/devices/platform/i8042/serio0/input/input4/event5

? Does that give any error message wrt. assigning the www key? Can you
please double-check in evtest that you really still get KEY_HOMEPAGE
after that?

Martin

-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Olaf Hering
Am 16.10.2015 um 15:45 schrieb Martin Pitt:

>   udevadm test-builtin keyboard 
> /devices/platform/i8042/serio0/input/input4/event5
> 
> ? Does that give any error message wrt. assigning the www key? Can you
> please double-check in evtest that you really still get KEY_HOMEPAGE
> after that?

root@probook:~ # udevadm test-builtin keyboard
/devices/platform/i8042/serio0/input/input4/event5
calling: test-builtin
=== trie on-disk ===
tool version:  224
file size: 7049404 bytes
header size 80 bytes
strings1762740 bytes
nodes  5286584 bytes
Load module index
timestamp of '/usr/lib/systemd/network' changed
Parsed configuration file /usr/lib/systemd/network/99-default.link
Created link configuration context.
Unload module index
Unloaded link configuration context.
root@probook:~ #

My entry from the initial mail works, no worries.

Olaf
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Olaf Hering
Am 16.10.2015 um 15:42 schrieb Martin Pitt:
> Hello Olaf,
> 
> Olaf Hering [2015-10-16 15:22 +0200]:
>> I just noticed that there is a catch al, which looks very odd:
>>
>> evdev:atkbd:dmi:bvn*:bvr*:bd*:svnHewlett-Packard*:pn*:pvr*
> 
> How does it look odd?

Wildcard for all of HP?!

>> Why would such a wildcard be correct?
> 
> As inconsistent as scan code assignments are between different
> vendors, the big ones at least sem to have some internal consistency,
> like HP, the "ThinkPad Extra Buttons", or the "Acer WMI hotkeys". We
> just found over time that a large number of different HP models all
> have the same keymap and it seems logical to factor out the common
> keys and then just add a few model specific adjustments.
> 
> The common map does not set b2 BTW, so disabling it won't change
> anything.

I disabled everything, and the result when doing the Fn+something is
like shown below. This means that at least the entries for 81, 89, 92,
97 and ee are already correct via wildcard. The other wildcards may not
hurt.

However b7 and 1d should be handled somehow. Not sure what the correct
entries for this model would be to handle print and interrupt (Its
labeled Untbr in german) keys. Right now both send wrong keys. Not sure
what sysrq is supposed to do anyway, at least GNOME does a screenshot.

Olaf

icon
sleep:Fn+F3  == value df, KEY_SLEEP
display:  Fn+F4  == value ee, unhandled

no label: Fn+ESC == value 81, unhandled
no label: Fn+F6  == value 8a, unhandled
battery:  Fn+F8  == value 89, unhandled
bright-:  Fn+F9  == value 92, unhandled
bright+:  Fn+F10 == value 97, unhandled
no label: Fn+F11 == value b3, unhandled

print:Fn+pos1== value b7, sysrq?
sysrq:Fn+ende== value 54, sysrq
pause:Fn+pgup== value c5, pause
intr: Fn+pgdn== value 1d, left ctrl?

Olaf
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] add new entry for HP ProBook 6555b to keyboard.hwdb

2015-10-16 Thread Martin Pitt
Olaf Hering [2015-10-16 16:21 +0200]:
> root@probook:~ # udevadm test-builtin keyboard
> /devices/platform/i8042/serio0/input/input4/event5
> calling: test-builtin
> === trie on-disk ===
> tool version:  224
> file size: 7049404 bytes
> header size 80 bytes
> strings1762740 bytes
> nodes  5286584 bytes
> Load module index
> timestamp of '/usr/lib/systemd/network' changed
> Parsed configuration file /usr/lib/systemd/network/99-default.link
> Created link configuration context.
> Unload module index
> Unloaded link configuration context.

That didn't work -- so apparently the device path has changed over a
reboot.

> My entry from the initial mail works, no worries.

Oh! I misunderstood you that it did *not* work, and you asked for
debugging why. I submitted a pull request:

  https://github.com/systemd/systemd/pull/1586

> # If your changes are generally applicable, open a bug report on
> #   http://bugs.freedesktop.org/enter_bug.cgi?product=systemd

This was already updated a while ago.

I didn't change the trigger comment, as the manpage also indicates
that triggering multiple path arguments is supposed to work. So let's
rather fix that.

Thanks,

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel