Re: [systemd-devel] clang-format: auto-formatting the code base of systemd

2019-01-08 Thread Umut Tezduyar Lindskog
On Sun, Jan 6, 2019 at 5:52 PM Lennart Poettering wrote: > > On Fr, 04.01.19 14:23, Sebastian Jennen (sebastian.jen...@gmx.de) wrote: > > > Hello systemd team, > > > > there is a pull request currently on systemd, which adds a .clang-format > > support, which you can find here: > > https://github.

Re: [systemd-devel] clang-format: auto-formatting the code base of systemd

2019-01-06 Thread Lennart Poettering
On Fr, 04.01.19 14:23, Sebastian Jennen (sebastian.jen...@gmx.de) wrote: > Hello systemd team, > > there is a pull request currently on systemd, which adds a .clang-format > support, which you can find here: > https://github.com/systemd/systemd/pull/11308 > > clang-format is an automatic formatter

Re: [systemd-devel] clang-format: auto-formatting the code base of systemd

2019-01-04 Thread Sebastian Jennen
Hello Giacinto, from a semantic point of view the source code should not change at all with clang-format. There is only one problem with the custom preprocessor pragma for the "new" keyword, which needs to be excluded explicitly. See old pull request here: https://github.com/systemd/systemd

Re: [systemd-devel] clang-format: auto-formatting the code base of systemd

2019-01-04 Thread Giacinto Cifelli
Hello Sebastian, > - reformats all existing code, which requires review this can be possibly be automated, by comparing the generated precompiled files. > > Cheers, Sebastian Jennen > Regards, Giacinto ___ systemd-devel mailing list systemd-devel@list

[systemd-devel] clang-format: auto-formatting the code base of systemd

2019-01-04 Thread Sebastian Jennen
Hello systemd team, there is a pull request currently on systemd, which adds a .clang-format support, which you can find here: https://github.com/systemd/systemd/pull/11308 clang-format is an automatic formatter for C code maintained by the llvm project. It works by tokenizing the source code