Re: [systemd-devel] kdbus: merge 3.17 branch into master?
Hi, I am having __NR_memfd_create not defined error on mips on systemd 216. I wanted to see the syscall numbers in 3.17 RC1 to patch missing.h but couldn't find them. What am I missing? On Tue, Aug 19, 2014 at 4:24 PM, Daniel Mack dan...@zonque.org wrote: On 08/19/2014 04:21 PM, Greg KH wrote: On Tue, Aug 19, 2014 at 04:08:15PM +0200, Daniel Mack wrote: Could you please try if temporarily reverting my top-most commit and then doing a 'make headers_install' in your kernel repo (before you build kdbus) fixes it? Yes, that works. And we can live with that, it's reasonable to rely on that kernel header now. Alright. Revert commit is pushed now. Thanks for testing! Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
Hi, On 08/22/2014 03:26 PM, Umut Tezduyar Lindskog wrote: I am having __NR_memfd_create not defined error on mips on systemd 216. I wanted to see the syscall numbers in 3.17 RC1 to patch missing.h but couldn't find them. What am I missing? We don't know the final syscall number yet, as it's not yet hooked up for MIPS. For now, I've pushed a dummy value to missing.h now, which should fix your problem. Sorry for that. Note that until this is fixed in the kernel, you won't be able to use systemd with kdbus on MIPS. Just curious - did you ever try this? Thanks, Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
Hi, On Fri, Aug 22, 2014 at 3:47 PM, Daniel Mack dan...@zonque.org wrote: Hi, On 08/22/2014 03:26 PM, Umut Tezduyar Lindskog wrote: I am having __NR_memfd_create not defined error on mips on systemd 216. I wanted to see the syscall numbers in 3.17 RC1 to patch missing.h but couldn't find them. What am I missing? We don't know the final syscall number yet, as it's not yet hooked up for MIPS. For now, I've pushed a dummy value to missing.h now, which should fix your problem. Sorry for that. No problem at all. Note that until this is fixed in the kernel, you won't be able to use systemd with kdbus on MIPS. Just curious - did you ever try this? Sorry, I haven't tested kdbus on mips. Umut Thanks, Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] kdbus: merge 3.17 branch into master?
Hi all, Now that memfd is merged into 3.17-rc1, should we merge the 3.17 branch in the kdbus tree into master as well? Right now, the test directory on master doesn't build properly on older kernels due to linux/memfd.h not being present, so it seems that we are already thinking the code is there: TARGET_CC kdbus-util.o kdbus-util.c:27:25: fatal error: linux/memfd.h: No such file or directory #include linux/memfd.h ^ thanks, greg k-h ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
Hi Greg On Tue, Aug 19, 2014 at 1:29 PM, Greg KH gre...@linuxfoundation.org wrote: Hi all, Now that memfd is merged into 3.17-rc1, should we merge the 3.17 branch in the kdbus tree into master as well? Right now, the test directory on master doesn't build properly on older kernels due to linux/memfd.h not being present, so it seems that we are already thinking the code is there: TARGET_CC kdbus-util.o kdbus-util.c:27:25: fatal error: linux/memfd.h: No such file or directory #include linux/memfd.h ^ I thought Daniel already cherry-picked the patches from the 3.17 branch into master? david@david-tp ~/dev/kdbus $ git log master..origin/3.17 --oneline b59133f metadata: drop support for kernels v3.15 307be39 Kconfig: depend on TMPFS 60a5b53 test: adopt new memfd interface 790a8a8 switch to upstream kernel memfd implementation (ABI+API break) 7219f86 metadata: follow 3.17 changes for current-start_time All these patches are available in master (with different sha1 due to cherry-pick). Thanks David ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On 08/19/2014 01:39 PM, David Herrmann wrote: Hi Greg On Tue, Aug 19, 2014 at 1:29 PM, Greg KH gre...@linuxfoundation.org wrote: Hi all, Now that memfd is merged into 3.17-rc1, should we merge the 3.17 branch in the kdbus tree into master as well? Right now, the test directory on master doesn't build properly on older kernels due to linux/memfd.h not being present, so it seems that we are already thinking the code is there: TARGET_CC kdbus-util.o kdbus-util.c:27:25: fatal error: linux/memfd.h: No such file or directory #include linux/memfd.h ^ I thought Daniel already cherry-picked the patches from the 3.17 branch into master? david@david-tp ~/dev/kdbus $ git log master..origin/3.17 --oneline b59133f metadata: drop support for kernels v3.15 307be39 Kconfig: depend on TMPFS 60a5b53 test: adopt new memfd interface 790a8a8 switch to upstream kernel memfd implementation (ABI+API break) 7219f86 metadata: follow 3.17 changes for current-start_time Yes, I already merged the patches I've been holding back until 3.17-rc1 was released. However, there was one missing detail to fix the build in test/ which I pushed now. Does it work for you? Thanks, Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On Tue, Aug 19, 2014 at 01:45:29PM +0200, Daniel Mack wrote: Yes, I already merged the patches I've been holding back until 3.17-rc1 was released. Ah, sorry, missed that. However, there was one missing detail to fix the build in test/ which I pushed now. Does it work for you? Nope, build is still broken: me/gregkh/linux/kdbus/test' TARGET_CC kdbus-enum.o In file included from ../kdbus.h:23:0, from kdbus-util.h:13, from kdbus-enum.c:20: /lib/modules/3.16.0+/build/include/uapi/linux/types.h:9:2: warning: #warning Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders; [-Wcpp] #warning Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders; ^ In file included from /lib/modules/3.16.0+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.16.0+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, from kdbus-util.h:13, from kdbus-enum.c:20: /lib/modules/3.16.0+/build/include/uapi/linux/stddef.h:1:28: fatal error: linux/compiler.h: No such file or directory #include linux/compiler.h ^ compilation terminated. Oh wait, I'm pointing it at a 3.16.0 release at the moment, let's change that... Nope, still broken, as you are relying on memfd.h to be included on the system: $ KERNELDIR=../gregkh/ make make -C ../gregkh/ M=/home/gregkh/linux/kdbus make[1]: Entering directory '/home/gregkh/linux/gregkh' Building modules, stage 2. MODPOST 1 modules make[1]: Leaving directory '/home/gregkh/linux/gregkh' make -C test KERNELDIR=../gregkh/ KBUILD_MODNAME=kdbus make[1]: Entering directory '/home/gregkh/linux/kdbus/test' TARGET_CC kdbus-enum.o TARGET_CC kdbus-util.o kdbus-util.c:27:25: fatal error: linux/memfd.h: No such file or directory #include linux/memfd.h ^ compilation terminated. I'll reboot into 3.17-rc1 and see if that solves this... thanks, greg k-h ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On Tue, Aug 19, 2014 at 07:37:12AM -0500, Greg KH wrote: I'll reboot into 3.17-rc1 and see if that solves this... Nope, same error as before: make[1]: Entering directory '/home/gregkh/linux/kdbus/test' TARGET_CC kdbus-enum.o In file included from ../kdbus.h:23:0, from kdbus-util.h:13, from kdbus-enum.c:20: /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:9:2: warning: #warning Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders; [-Wcpp] #warning Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders; ^ In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, from kdbus-util.h:13, from kdbus-enum.c:20: /lib/modules/3.17.0-rc1+/build/include/uapi/linux/stddef.h:1:28: fatal error: linux/compiler.h: No such file or directory #include linux/compiler.h ^ compilation terminated. How are you building this file? thanks, greg k-h ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On 08/19/2014 02:37 PM, Greg KH wrote: $ KERNELDIR=../gregkh/ make make -C ../gregkh/ M=/home/gregkh/linux/kdbus make[1]: Entering directory '/home/gregkh/linux/gregkh' Building modules, stage 2. MODPOST 1 modules make[1]: Leaving directory '/home/gregkh/linux/gregkh' make -C test KERNELDIR=../gregkh/ KBUILD_MODNAME=kdbus Hmm, yes. KERNELDIR has to be an absolute path. I pushed a fix to address this and convert a possible relative path into an absolute one. Does this help? Thanks, Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On 08/19/2014 02:47 PM, Greg KH wrote: In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, Ok, got it now. No idea why it worked on my system, but a fix for now is to make cpp look at the system include file search pathes first, and then fall back to $(KERNELDIR)/include/uapi. Care to test again? Thanks, Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On Tue, Aug 19, 2014 at 03:24:39PM +0200, Daniel Mack wrote: On 08/19/2014 02:47 PM, Greg KH wrote: In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, Ok, got it now. No idea why it worked on my system, but a fix for now is to make cpp look at the system include file search pathes first, and then fall back to $(KERNELDIR)/include/uapi. Care to test again? Close, I now get a bunch of these warnings: cc1: note: obsolete option -I- used, please use -iquote instead and then finally a failure of: kdbus-util.c:173:16: error: ‘__NR_memfd_create’ undeclared (first use in this function) ret = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On 08/19/2014 03:56 PM, Greg KH wrote: On Tue, Aug 19, 2014 at 03:24:39PM +0200, Daniel Mack wrote: On 08/19/2014 02:47 PM, Greg KH wrote: In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, Ok, got it now. No idea why it worked on my system, but a fix for now is to make cpp look at the system include file search pathes first, and then fall back to $(KERNELDIR)/include/uapi. Care to test again? Close, I now get a bunch of these warnings: cc1: note: obsolete option -I- used, please use -iquote instead and then finally a failure of: kdbus-util.c:173:16: error: ‘__NR_memfd_create’ undeclared (first use in this function) ret = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); Ok, cpp is really confused about which headers to look at now. I guess we have to rely on the kernel headers being available under $(KERNELDIR)/usr/include. Could you please try if temporarily reverting my top-most commit and then doing a 'make headers_install' in your kernel repo (before you build kdbus) fixes it? Thanks, Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On Tue, Aug 19, 2014 at 08:56:14AM -0500, Greg KH wrote: On Tue, Aug 19, 2014 at 03:24:39PM +0200, Daniel Mack wrote: On 08/19/2014 02:47 PM, Greg KH wrote: In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, Ok, got it now. No idea why it worked on my system, but a fix for now is to make cpp look at the system include file search pathes first, and then fall back to $(KERNELDIR)/include/uapi. Care to test again? Close, I now get a bunch of these warnings: cc1: note: obsolete option -I- used, please use -iquote instead and then finally a failure of: kdbus-util.c:173:16: error: ‘__NR_memfd_create’ undeclared (first use in this function) ret = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); I also confirm, HEAD gives these errors! However yesterday before any change to Makefile, I got the same error that was first reported by Greg, and to compile and test kdbus, I just added export KERNELDIR to the root Makefile, didn't bother to search... -- Djalal Harouni http://opendz.org ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On Tue, Aug 19, 2014 at 04:08:15PM +0200, Daniel Mack wrote: On 08/19/2014 03:56 PM, Greg KH wrote: On Tue, Aug 19, 2014 at 03:24:39PM +0200, Daniel Mack wrote: On 08/19/2014 02:47 PM, Greg KH wrote: In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, Ok, got it now. No idea why it worked on my system, but a fix for now is to make cpp look at the system include file search pathes first, and then fall back to $(KERNELDIR)/include/uapi. Care to test again? Close, I now get a bunch of these warnings: cc1: note: obsolete option -I- used, please use -iquote instead and then finally a failure of: kdbus-util.c:173:16: error: ‘__NR_memfd_create’ undeclared (first use in this function) ret = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); Ok, cpp is really confused about which headers to look at now. I guess we have to rely on the kernel headers being available under $(KERNELDIR)/usr/include. Could you please try if temporarily reverting my top-most commit and then doing a 'make headers_install' in your kernel repo (before you build kdbus) fixes it? Daniel, I confirm here. I just did that and it builds. Thanks -- Djalal Harouni http://opendz.org ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On Tue, Aug 19, 2014 at 04:08:15PM +0200, Daniel Mack wrote: On 08/19/2014 03:56 PM, Greg KH wrote: On Tue, Aug 19, 2014 at 03:24:39PM +0200, Daniel Mack wrote: On 08/19/2014 02:47 PM, Greg KH wrote: In file included from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0, from /lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13, from ../kdbus.h:23, Ok, got it now. No idea why it worked on my system, but a fix for now is to make cpp look at the system include file search pathes first, and then fall back to $(KERNELDIR)/include/uapi. Care to test again? Close, I now get a bunch of these warnings: cc1: note: obsolete option -I- used, please use -iquote instead and then finally a failure of: kdbus-util.c:173:16: error: ‘__NR_memfd_create’ undeclared (first use in this function) ret = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); Ok, cpp is really confused about which headers to look at now. I guess we have to rely on the kernel headers being available under $(KERNELDIR)/usr/include. Could you please try if temporarily reverting my top-most commit and then doing a 'make headers_install' in your kernel repo (before you build kdbus) fixes it? Yes, that works. And we can live with that, it's reasonable to rely on that kernel header now. thanks, greg k-h ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] kdbus: merge 3.17 branch into master?
On 08/19/2014 04:21 PM, Greg KH wrote: On Tue, Aug 19, 2014 at 04:08:15PM +0200, Daniel Mack wrote: Could you please try if temporarily reverting my top-most commit and then doing a 'make headers_install' in your kernel repo (before you build kdbus) fixes it? Yes, that works. And we can live with that, it's reasonable to rely on that kernel header now. Alright. Revert commit is pushed now. Thanks for testing! Daniel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
