Re: [systemd-devel] minimal-uclibc: systemd fails with `src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use in this function)`

2011-05-11 Thread Gustavo Sverzut Barbieri
On Wed, May 11, 2011 at 2:58 AM, Thierry Reding
thierry.red...@avionic-design.de wrote:
 * Paul Menzel wrote:
 Dear OE folks,


 task compile of `systemd_git.bb` fails with the following error message
 using `minimal-uclibc` for `MACHINE = beagleboard`. Using `minimal`,
 i. e. EGLIBC, works.

         […]
         |   CC     src/libsystemd_core_la-manager.lo
         | src/manager.c: In function 'manager_new':
         | src/manager.c:257:9: warning: implicit declaration of function 
 'epoll_create1' [-Wimplicit-function-declaration]
         | src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use 
 in this function)
         | src/manager.c:257:42: note: each undeclared identifier is reported 
 only once for each function it appears in
         | src/manager.c: In function 'manager_process_notify_fd':
         | src/manager.c:1956:25: warning: cast increases required alignment 
 of target type [-Wcast-align]
         […]

 `manager.c` includes

         #include sys/epoll.h
         #include fcntl.h

 which I read should contain that definition. But looking at `fcntl.h` I
 could not find it. I then looked in

         
 ./minimal-uclibc-dev/sysroots/armv7a-oe-linux-uclibceabi/usr/include/sys/epoll.h

 where it is defined for EGLIBC but not for uClibc. I also found the
 patch for uClibc [1] but there `EPOLL_CLOEXEC` is enclosed in `#if 0`.

 I am no uClibc expert, but do you know if uClibc will provide
 `EPOLL_CLOEXEC` in the near future? How should systemd fix that?

 uClibc is also missing an implementation of the epoll_create1() syscall. I'm
 using a patch against uClibc to fix a similar issue in udev but haven't
 gotten around to sending it upstream yet.

Koen just noticed that his eglibc was missing accept4(), due old
kernel headers and likely something missing in eglibc's itself. That
was not visible as a compile-time error, but was causing issues. I'd
check if uclibc implements that as well.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] minimal-uclibc: systemd fails with `src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use in this function)`

2011-05-10 Thread Paul Menzel
Dear OE folks,


task compile of `systemd_git.bb` fails with the following error message
using `minimal-uclibc` for `MACHINE = beagleboard`. Using `minimal`,
i. e. EGLIBC, works.

[…]
|   CC src/libsystemd_core_la-manager.lo
| src/manager.c: In function 'manager_new':
| src/manager.c:257:9: warning: implicit declaration of function 
'epoll_create1' [-Wimplicit-function-declaration]
| src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use in 
this function)
| src/manager.c:257:42: note: each undeclared identifier is reported 
only once for each function it appears in
| src/manager.c: In function 'manager_process_notify_fd':
| src/manager.c:1956:25: warning: cast increases required alignment of 
target type [-Wcast-align]
[…]

`manager.c` includes

#include sys/epoll.h
#include fcntl.h

which I read should contain that definition. But looking at `fcntl.h` I
could not find it. I then looked in


./minimal-uclibc-dev/sysroots/armv7a-oe-linux-uclibceabi/usr/include/sys/epoll.h

where it is defined for EGLIBC but not for uClibc. I also found the
patch for uClibc [1] but there `EPOLL_CLOEXEC` is enclosed in `#if 0`.

I am no uClibc expert, but do you know if uClibc will provide
`EPOLL_CLOEXEC` in the near future? How should systemd fix that?

Please find attached a patch updating systemd to a newer including a
commit fixing another problem with systemd and uClibc.


Thanks,

Paul


[1] http://lists.uclibc.org/pipermail/uclibc-cvs/2011-March/028879.html
From a135d73cfc7f4c0eb8da344d5bf0d49668ffdbf9 Mon Sep 17 00:00:00 2001
From: Paul Menzel paulepan...@users.sourceforge.net
Date: Tue, 10 May 2011 09:19:02 +0200
Subject: [PATCH] systemd: bump srcrev
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

• better uClibc support [1], but still fails in `src/manager.c`
• Ȧngström support merged upstream [2]

Still needs native docbook-xsl which is not available in OE.

[1] http://cgit.freedesktop.org/systemd/commit/?id=ec2002f84928c0b5921a961cb2b8637563f29daa
[2] http://cgit.freedesktop.org/systemd/commit/?id=1bd8b8184ee3bc7fc023d6d6dfb2ca99fb6612f3

Signed-off-by: Paul Menzel paulepan...@users.sourceforge.net
---
 .../systemd-v26/0003-Angstrom-support.patch|  165 
 recipes/systemd/systemd_git.bb |3 +-
 2 files changed, 1 insertions(+), 167 deletions(-)
 delete mode 100644 recipes/systemd/systemd-v26/0003-Angstrom-support.patch

diff --git a/recipes/systemd/systemd-v26/0003-Angstrom-support.patch b/recipes/systemd/systemd-v26/0003-Angstrom-support.patch
deleted file mode 100644
index c75cee4..000
--- a/recipes/systemd/systemd-v26/0003-Angstrom-support.patch
+++ /dev/null
@@ -1,165 +0,0 @@
-From 0fa5b59c5f484c80453e9d3201b87e4253f8bec3 Mon Sep 17 00:00:00 2001
-From: Koen Kooi k...@dominion.thruhere.net
-Date: Thu, 5 May 2011 17:15:41 +0200
-Subject: [PATCH 3/3] Angstrom support
-
-This commit consists of the initial work to include Angstrom as a ported
-distribution for systemd.
-
-Angstrom tries to follow the debian way as much as possible, but deviates
-where it doesn't make sense for 'embedded'.
-
-Signed-off-by: Koen Kooi k...@dominion.thruhere.net

- Makefile.am|7 +++
- configure.ac   |7 +++
- src/locale-setup.c |2 +-
- src/service.c  |   10 +-
- src/util.c |   12 
- 5 files changed, 32 insertions(+), 6 deletions(-)
-
-diff --git a/Makefile.am b/Makefile.am
-index 49d2ee8..f3f7818 100644
 a/Makefile.am
-+++ b/Makefile.am
-@@ -96,6 +96,12 @@ AM_CPPFLAGS += \
- 	-DKBD_SETFONT=\/bin/setfont\ \
- 	-DDEFAULT_FONT=\LatArCyrHeb-16\
- else
-+if TARGET_ANGSTROM
-+AM_CPPFLAGS += \
-+	-DKBD_LOADKEYS=\/usr/bin/loadkeys\ \
-+	-DKBD_SETFONT=\/usr/bin/setfont\ \
-+	-DDEFAULT_FONT=\LatArCyrHeb-16\
-+else
- AM_CPPFLAGS += \
- 	-DKBD_LOADKEYS=\/bin/loadkeys\ \
- 	-DKBD_SETFONT=\/bin/setfont\ \
-@@ -105,6 +111,7 @@ endif
- endif
- endif
- endif
-+endif
- 
- rootbin_PROGRAMS = \
- 	systemd \
-diff --git a/configure.ac b/configure.ac
-index dcd4b9d..b5b7ac3 100644
 a/configure.ac
-+++ b/configure.ac
-@@ -295,6 +295,7 @@ if test z$with_distro = z; then
- test -f /etc/altlinux-release  with_distro=altlinux
- test -f /etc/mandriva-release  with_distro=mandriva
- test -f /etc/meego-release  with_distro=meego
-+test -f /etc/angstrom-version  with_distro=angstrom
- if test x`lsb_release -is 2/dev/null` = xUbuntu; then
- with_distro=ubuntu
- fi
-@@ -375,6 +376,11 @@ case $with_distro in
- AC_DEFINE(TARGET_MEEGO, [], [Target is MeeGo])
- M4_DISTRO_FLAG=-DTARGET_MEEGO=1
- 		;;
-+angstrom)
-+SYSTEM_SYSVRCND_PATH=/etc
-+AC_DEFINE(TARGET_ANGSTROM, [], [Target is Ångström])
-+   

Re: [systemd-devel] minimal-uclibc: systemd fails with `src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use in this function)`

2011-05-10 Thread Paul Menzel
Dear systemd folks,


I am sorry for this message. I first wanted it to send to systemd-devel
but decided to send it to openembedded-devel instead and forgot to
update the address. If you have any insight though it is most welcome.


Thanks,

PAul


signature.asc
Description: This is a digitally signed message part
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] minimal-uclibc: systemd fails with `src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use in this function)`

2011-05-10 Thread Thierry Reding
* Paul Menzel wrote:
 Dear OE folks,
 
 
 task compile of `systemd_git.bb` fails with the following error message
 using `minimal-uclibc` for `MACHINE = beagleboard`. Using `minimal`,
 i. e. EGLIBC, works.
 
 […]
 |   CC src/libsystemd_core_la-manager.lo
 | src/manager.c: In function 'manager_new':
 | src/manager.c:257:9: warning: implicit declaration of function 
 'epoll_create1' [-Wimplicit-function-declaration]
 | src/manager.c:257:42: error: 'EPOLL_CLOEXEC' undeclared (first use 
 in this function)
 | src/manager.c:257:42: note: each undeclared identifier is reported 
 only once for each function it appears in
 | src/manager.c: In function 'manager_process_notify_fd':
 | src/manager.c:1956:25: warning: cast increases required alignment 
 of target type [-Wcast-align]
 […]
 
 `manager.c` includes
 
 #include sys/epoll.h
 #include fcntl.h
 
 which I read should contain that definition. But looking at `fcntl.h` I
 could not find it. I then looked in
 
 
 ./minimal-uclibc-dev/sysroots/armv7a-oe-linux-uclibceabi/usr/include/sys/epoll.h
 
 where it is defined for EGLIBC but not for uClibc. I also found the
 patch for uClibc [1] but there `EPOLL_CLOEXEC` is enclosed in `#if 0`.
 
 I am no uClibc expert, but do you know if uClibc will provide
 `EPOLL_CLOEXEC` in the near future? How should systemd fix that?

uClibc is also missing an implementation of the epoll_create1() syscall. I'm
using a patch against uClibc to fix a similar issue in udev but haven't
gotten around to sending it upstream yet.

Thierry


pgpHEt4PQnZBY.pgp
Description: PGP signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel