Re: [systemd-devel] systemd unit review requested

2013-12-11 Thread Lennart Poettering
On Wed, 11.12.13 12:34, Peter Hutterer (peter.hutte...@who-t.net) wrote: > > If a module exposes those alias lines then the module is auto-loaded by > > udev as soon as matching hardware shows up. That's the preferable way to > > load kernel modules these days, instead of loading them explicitly t

Re: [systemd-devel] systemd unit review requested

2013-12-10 Thread Kay Sievers
On Wed, Dec 11, 2013 at 3:34 AM, Peter Hutterer wrote: > ok, after spending half the day going down the most likely wrong track: are > we talking about auto-loading the module once inputattach is launched, or > dropping the need for inputattach? > > because if it's the former then yes, I can conf

Re: [systemd-devel] systemd unit review requested

2013-12-10 Thread Peter Hutterer
On Tue, Dec 10, 2013 at 08:20:17PM +0100, Lennart Poettering wrote: > On Mon, 09.12.13 12:18, Peter Hutterer (peter.hutte...@who-t.net) wrote: > > > > > On Fri, Dec 06, 2013 at 04:10:02PM +0100, Kay Sievers wrote: > > > On Fri, Dec 6, 2013 at 7:20 AM, Peter Hutterer > > > wrote: > > > > > > >>

Re: [systemd-devel] systemd unit review requested

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 12:18, Peter Hutterer (peter.hutte...@who-t.net) wrote: > > On Fri, Dec 06, 2013 at 04:10:02PM +0100, Kay Sievers wrote: > > On Fri, Dec 6, 2013 at 7:20 AM, Peter Hutterer > > wrote: > > > > >> >It also depends on the wacom_w8001 and how it reacts when it's loaded > > >> >and

Re: [systemd-devel] systemd unit review requested

2013-12-08 Thread Peter Hutterer
On Thu, Dec 05, 2013 at 01:24:10PM +, "Jóhann B. Guðmundsson" wrote: [...] > So we need an udev wacom-serial-driver rule that might look like > this for the wacom serial devices > > ACTION=="remove", GOTO="drivers_end" > ENV{MODALIAS}=="?*", RUN{builtin}="kmod load $env{MODALIAS}" > SUBSYSTEM=

Re: [systemd-devel] systemd unit review requested

2013-12-08 Thread Peter Hutterer
On Fri, Dec 06, 2013 at 04:10:02PM +0100, Kay Sievers wrote: > On Fri, Dec 6, 2013 at 7:20 AM, Peter Hutterer > wrote: > > >> >It also depends on the wacom_w8001 and how it reacts when it's loaded > >> >and no hardware is present. > >> > > >> >Peter, couldn't this module be autoloaded? > > > > t

Re: [systemd-devel] systemd unit review requested

2013-12-06 Thread Kay Sievers
On Fri, Dec 6, 2013 at 7:20 AM, Peter Hutterer wrote: >> >It also depends on the wacom_w8001 and how it reacts when it's loaded >> >and no hardware is present. >> > >> >Peter, couldn't this module be autoloaded? > > the module just sits there, it needs to be triggered by > inputattach to actually

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Peter Hutterer
On Thu, Dec 05, 2013 at 01:24:10PM +, "Jóhann B. Guðmundsson" wrote: > > On 12/05/2013 12:28 PM, Michael Biebl wrote: > >2013/12/5 "Jóhann B. Guðmundsson": > >>On 12/05/2013 06:50 AM, Peter Hutterer wrote: > >>>ExecStartPre=/usr/sbin/modprobe wacom_w8001 > >>Add a configuration file called wac

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Peter Hutterer
On Thu, Dec 05, 2013 at 04:38:45PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Dec 05, 2013 at 04:27:51PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Dec 05, 2013 at 04:50:54PM +1000, Peter Hutterer wrote: > > > the new rule now is: > > > > > > SUBSYSTEM=="tty|pnp", KERNEL=="ttyS

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Tom Gundersen
On 5 Dec 2013 07:48, "Peter Hutterer" wrote: > > When I fired up F20 on one of my laptops here I noticed that inputattach > doesn't work anymore for serial Wacom devices. It used to be started through > udev, but that doesn't work anymore. So moving to a systemd service it is, > but I'd like a rev

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread David Timothy Strauss
On Thu, Dec 5, 2013 at 7:29 AM, Colin Guthrie wrote: > The above statement not withstanding, but the Type and RemainAfterExit > applies only to ExecStart. This unit calls modprobe in ExecStartPre > which is always expected to do something and return. So this branch of > the thread really doesn't a

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 05, 2013 at 04:27:51PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Dec 05, 2013 at 04:50:54PM +1000, Peter Hutterer wrote: > > the new rule now is: > > > > SUBSYSTEM=="tty|pnp", KERNEL=="ttyS[0-9]*", ATTRS{id}=="WACf*", \ > > ENV{SYSTEMD_WANTS}="wacom-inputattach@%k.service

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Colin Guthrie
'Twas brillig, and "Jóhann B. Guðmundsson" at 05/12/13 14:30 did gyre and gimble: > > On 12/05/2013 01:57 PM, David Timothy Strauss wrote: >> On Thu, Dec 5, 2013 at 3:53 AM, "Jóhann B. Guðmundsson" >> wrote: >>> Never use a systemd unit to call modprobe. >> And, even if you did, modprobe would be

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 05, 2013 at 04:50:54PM +1000, Peter Hutterer wrote: > the new rule now is: > > SUBSYSTEM=="tty|pnp", KERNEL=="ttyS[0-9]*", ATTRS{id}=="WACf*", \ > ENV{SYSTEMD_WANTS}="wacom-inputattach@%k.service",TAG+="systemd" > > > And the matching wacom-inputattach@.service file shows: > > [

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Jóhann B. Guðmundsson
On 12/05/2013 01:57 PM, David Timothy Strauss wrote: On Thu, Dec 5, 2013 at 3:53 AM, "Jóhann B. Guðmundsson" wrote: Never use a systemd unit to call modprobe. And, even if you did, modprobe would be Type=oneshot (maybe also with RemainAfterExit=true), definitely not Type=simple. You never a

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread David Timothy Strauss
On Thu, Dec 5, 2013 at 3:53 AM, "Jóhann B. Guðmundsson" wrote: > Never use a systemd unit to call modprobe. And, even if you did, modprobe would be Type=oneshot (maybe also with RemainAfterExit=true), definitely not Type=simple. ___ systemd-devel mailin

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Jóhann B. Guðmundsson
On 12/05/2013 12:28 PM, Michael Biebl wrote: 2013/12/5 "Jóhann B. Guðmundsson": On 12/05/2013 06:50 AM, Peter Hutterer wrote: ExecStartPre=/usr/sbin/modprobe wacom_w8001 Add a configuration file called wacom-w8001.conf to /etc/modules-load.d directory with the following content to load the mo

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Michael Biebl
2013/12/5 "Jóhann B. Guðmundsson" : > > On 12/05/2013 06:50 AM, Peter Hutterer wrote: >> >> ExecStartPre=/usr/sbin/modprobe wacom_w8001 > > > Add a configuration file called wacom-w8001.conf to /etc/modules-load.d > directory with the following content to load the module > ( /etc/modules-load.d/wac

Re: [systemd-devel] systemd unit review requested

2013-12-05 Thread Jóhann B. Guðmundsson
On 12/05/2013 06:50 AM, Peter Hutterer wrote: ExecStartPre=/usr/sbin/modprobe wacom_w8001 Add a configuration file called wacom-w8001.conf to /etc/modules-load.d directory with the following content to load the module ( /etc/modules-load.d/wacom-w8001.conf ) # Load wacom_w8001 at boot wacom_

[systemd-devel] systemd unit review requested

2013-12-04 Thread Peter Hutterer
When I fired up F20 on one of my laptops here I noticed that inputattach doesn't work anymore for serial Wacom devices. It used to be started through udev, but that doesn't work anymore. So moving to a systemd service it is, but I'd like a review of the changes please. The goal is to start inputat